Introduce testing #169
Open
Introduce testing #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch brings Jest into the repo, adds coverage to timeSince, and provides the very beginning of a set of browser-based integration tests. The integration tests are skipped by default because they are too fragile, but can be run locally by changing describe.skip to describe.
johnholdun
commented
Nov 15, 2023
| "jest": true | ||
| }, | ||
| "globals": { | ||
| "page": true |
Collaborator
Author
There was a problem hiding this comment.
I think there ought to be a way to only allow this page global in *.test.js files but I'm not sure what it is
johnholdun
commented
Nov 15, 2023
| }); | ||
|
|
||
| test('the future', () => { | ||
| expect(util.timeSince(now.valueOf() + 1000, now)).toEqual('-1s ago'); |
Collaborator
Author
There was a problem hiding this comment.
This is undesirable and basically undefined behavior, but at least now we can be confident that this is what happens!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings Jest into the repo, adds coverage to timeSince, and provides the very beginning of a set of browser-based integration tests. The integration tests are skipped by default because they are too fragile, but can be run locally by changing
describe.skiptodescribe.I have no strong feelings on jest vs any other testing framework—this is just the one I've used the most. Happy to accept any alternatives!
Closes #21.