Replying to inline comments #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to make this first version work for replying to inline comments, however I need to clear the code and make it more robust. The only thing I noticed that is causing some errors in some pages is that
poscomputed by our algorithm does not always matchoriginalPositionreturned by Github GraphQL API for a given comment.In my initial design this is necessary to build a lookup table (
github-review-pos->databaseid) to index thedatabaseIDof the comment that we will be replying to. I will dig more into it, this PR is a working in progress.This issue seems related to
outdatedinformation in the PR/review API. Thepositionfield for some review comments are updated, but others are returned asnull. :/Note: This build on top of #79 so commits are duplicated here