Limit the maximum number of retries for starting opsqueue #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should eventually fail if we can't start the server.
There was a problem hiding this comment.
Pull request overview
This PR modifies the server startup retry behavior to fail after a limited number of attempts rather than retrying indefinitely. This ensures that if the server cannot be started (e.g., due to missing dependencies like rust-src for Rust analyzer), it will eventually fail with a clear error instead of retrying forever.
Key Changes:
- Changed the server startup retry policy from unlimited retries to a maximum of 10 attempts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@ReinierMaas I'm only back next week so ask Sander or Adrian for a review if you want it before then. |
SanderHageman
changed the title
SanderHageman
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should eventually fail if we can't start the server.