Add RouteBuilderToCallbackFirstRector for CakePHP 6.0 #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2025
Reorders RouteBuilder scope/prefix/plugin/resources method arguments
to have callback second and params/options third.
Changes:
- scope('/path', $params, $callback) -> scope('/path', $callback, $params)
- prefix('name', $params, $callback) -> prefix('name', $callback, $params)
- plugin('name', $params, $callback) -> plugin('name', $callback, $params)
- resources('name', $options) -> resources('name', null, $options)
Empty param arrays are automatically removed.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
dereuromark
force-pushed
the
6.x-routebuilder-callback-first
branch
from
2114279 to
06d57bc
Compare
Member
Not a big deal, but |
Member
Author
|
Isnt the main PR still open? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Rector rule to migrate RouteBuilder method calls for CakePHP 6.0.
This supports cakephp/cakephp#19095 which removes argument overloading from RouteBuilder methods.
Changes
scope('/path', $params, $callback)→scope('/path', $callback, $params)prefix('name', $params, $callback)→prefix('name', $callback, $params)plugin('name', $params, $callback)→plugin('name', $callback, $params)resources('name', $options)→resources('name', null, $options)Empty param arrays are automatically removed when the new signature only needs two arguments.
Test plan
🤖 Generated with Claude Code