Skip to content

Added missing id field from mastercard action. (bunq/sdk_csharp#52) #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2018
Merged

Added missing id field from mastercard action. (bunq/sdk_csharp#52) #74

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a96e010
Added missing id field from masgtercard action. (bunq/sdk_csharp#52)
Dec 30, 2017
ba330de
Merge branch 'develop' into bunq/sdk_csharp#52-fix-missing-mastercard…
andrederoos Jan 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions BunqSdk/Model/Generated/Endpoint/MasterCardAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ public class MasterCardAction : BunqModel
/// </summary>
private const string OBJECT_TYPE = "MasterCardAction";

/// <summary>
/// The id of the MastercardAction.
/// </summary>
[JsonProperty(PropertyName = "id")]
public int? Id { get; private set; }

/// <summary>
/// The id of the monetary account this action links to.
/// </summary>
Expand Down Expand Up @@ -195,6 +201,11 @@ public static BunqResponse<List<MasterCardAction>> List(ApiContext apiContext, i
/// </summary>
public override bool IsAllFieldNull()
{
if (this.Id != null)
Copy link

@epels epels Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.Id.HasValue?

Copy link
Contributor Author

@OGKevin OGKevin Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code, please create follow up issue as this requires changes in the generator it self.

{
return false;
}

if (this.MonetaryAccountId != null)
{
return false;
Expand Down
2 changes: 1 addition & 1 deletion BunqSdk/Model/Generated/Endpoint/ShareInviteBankResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public class ShareInviteBankResponse : BunqModel
public string Status { get; private set; }

/// <summary>
/// The share type: STANDARD.
/// The share type, either STANDARD or MUTUAL.
/// </summary>
[JsonProperty(PropertyName = "share_type")]
public string ShareType { get; private set; }
Expand Down