Skip to content

Improve issue and pr template. (bunq/sdk_csharp#64) #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 2, 2018
Merged

Improve issue and pr template. (bunq/sdk_csharp#64) #65

merged 5 commits into from
Jan 2, 2018

Conversation

@OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Dec 25, 2017

Closes #64

@OGKevin OGKevin added this to the 0.12.5 milestone Dec 25, 2017
@OGKevin OGKevin self-assigned this Dec 25, 2017
OGKevin
OGKevin commented Dec 25, 2017
View reviewed changes
Copy link
Contributor Author

@OGKevin OGKevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some weird unneeded spaces 😅

.github/ISSUE_TEMPLATE.md Outdated

## What should happen:
1.
## Steps to reproduce:
Copy link
Contributor Author

@OGKevin OGKevin Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This space can go

.github/ISSUE_TEMPLATE.md Outdated
## What should happen:
1.
## Steps to reproduce:
1.
Copy link
Contributor Author

@OGKevin OGKevin Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space can go

.github/ISSUE_TEMPLATE.md Outdated
## What happens:
1.
## What should happen:
1.
Copy link
Contributor Author

@OGKevin OGKevin Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space

.github/ISSUE_TEMPLATE.md Outdated

## Logs
- Logs
## What happens:
Copy link
Contributor Author

@OGKevin OGKevin Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space

.github/ISSUE_TEMPLATE.md Outdated
## Logs
- Logs
## What happens:
1.
Copy link
Contributor Author

@OGKevin OGKevin Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space

@OGKevin OGKevin changed the title Improve issue and pr template. (Feature/bunq/sdk_csharp#64) Improve issue and pr template. (bunq/sdk_csharp#64) Dec 25, 2017
@OGKevin OGKevin force-pushed the feature/bunq/sdk_csharp#64-imporve-issue-and-pr-tempplate branch from bfcec28 to 28e5cf6 Compare December 29, 2017 22:04
@OGKevin
Copy link
Contributor Author

OGKevin commented Jan 2, 2018

@epels all yours please 👀

@OGKevin OGKevin requested a review from epels January 2, 2018 09:14
epels
epels approved these changes Jan 2, 2018
View reviewed changes
Copy link

@epels epels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OGKevin
Copy link
Contributor Author

OGKevin commented Jan 2, 2018

@andrederoos all yours please 👀

@OGKevin OGKevin requested a review from andrederoos January 2, 2018 11:11
@OGKevin OGKevin assigned andrederoos and unassigned epels Jan 2, 2018
@andrederoos andrederoos merged commit 025537a into develop Jan 2, 2018
@andrederoos andrederoos deleted the feature/bunq/sdk_csharp#64-imporve-issue-and-pr-tempplate branch January 2, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrederoos andrederoos andrederoos approved these changes

+1 more reviewer

@epels epels epels approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andrederoos andrederoos

@OGKevin OGKevin

Labels

Can be merged Reviewed by André

Projects

None yet

Milestone

0.12.5

Development

Successfully merging this pull request may close these issues.

4 participants

@OGKevin @andrederoos @epels