Skip to content

Conversation

@btschwertfeger
Copy link
Owner

  • Updating the type annotation, since the function only works well with xarray.core.dataarray.DataArray.
  • Update pre-commit hooks

@btschwertfeger btschwertfeger added the Bug Something isn't working label Jan 25, 2025
@btschwertfeger btschwertfeger added this to the Upcoming Release milestone Jan 25, 2025
@btschwertfeger btschwertfeger self-assigned this Jan 25, 2025
@codecov
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.88%. Comparing base (3addde7) to head (04aca9e).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
cmethods/core.py 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   96.17%   95.88%   -0.30%     
==========================================
  Files           7        7              
  Lines         314      316       +2     
==========================================
+ Hits          302      303       +1     
- Misses         12       13       +1     
Flag Coverage Δ
unittests 95.73% <92.30%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmethods/__init__.py 92.00% <100.00%> (+0.16%) ⬆️
cmethods/utils.py 96.55% <100.00%> (ø)
cmethods/core.py 90.56% <75.00%> (-1.75%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@btschwertfeger btschwertfeger marked this pull request as ready for review January 31, 2025 18:03
@btschwertfeger btschwertfeger enabled auto-merge (squash) January 31, 2025 18:04
@btschwertfeger btschwertfeger merged commit a14d254 into master Jan 31, 2025
34 checks passed
@btschwertfeger btschwertfeger deleted the update-type-annotations branch January 31, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants