Skip to content

Conversation

@jackielu3
Copy link
Collaborator

@jackielu3 jackielu3 commented Dec 9, 2025

Description of Changes

Provide a brief description of the changes you've made.

Linked Issues / Tickets

Reference any related issues or tickets, e.g. "Closes #123".

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes
  • I have run npm run doc and npm run lint one final time before requesting a review
  • I have fixed all linter errors to ensure these changes are compliant with ts-standard
  • I have run npm version patch so that my changes will trigger a new version to be released when they are merged

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

🏁 Benchmark Comparison (Node 22)

Comparing this PR (072e651) against master (0b96416).

⚠️ 1 regression detected (>5% slower).

Regressions

  • ⚠️ Atomic BEEF – Transaction.fromAtomicBEEF is 10.38% slower (4.36 ms vs 3.95 ms).
Benchmark Metric PR Branch Master Δ Change
BigNumber Arithmetic mul large numbers 8.75 ms 8.76 ms -0.01 ms -0.11%
BigNumber Arithmetic add large numbers 1.77 ms 1.79 ms -0.02 ms -1.12%
BigNumber Serialization toSm big 2.70 ms 2.73 ms -0.03 ms -1.10%
BigNumber Serialization toSm little 2.75 ms 2.77 ms -0.02 ms -0.72%
BigNumber Serialization fromSm big 3.15 ms 3.21 ms -0.06 ms -1.87%
BigNumber Serialization fromSm little 3.24 ms 3.27 ms -0.03 ms -0.92%
BigNumber Serialization fromScriptNum 3.26 ms 3.28 ms -0.02 ms -0.61%
Script Serialization Big script round trip 3.35 ms 3.40 ms -0.05 ms -1.47%
Transaction Verification deep chain verify 478.12 ms 482.35 ms -4.23 ms -0.88%
Transaction Verification wide transaction verify 501.35 ms 501.71 ms -0.36 ms -0.07%
Transaction Verification large tx verify 251.12 ms 252.24 ms -1.12 ms -0.44%
Transaction Verification nested inputs verify 113.93 ms 115.98 ms -2.05 ms -1.77%
Symmetric Key encrypt large 2MB 1681.62 ms 1684.45 ms -2.83 ms -0.17%
Symmetric Key decrypt large 2MB 1667.01 ms 1673.72 ms -6.71 ms -0.40%
Symmetric Key encrypt 50 small 7.56 ms 7.52 ms +0.04 ms +0.53%
Symmetric Key decrypt 50 small 7.32 ms 7.27 ms +0.05 ms +0.69%
Symmetric Key encrypt 200 medium 176.72 ms 178.64 ms -1.92 ms -1.07%
Symmetric Key decrypt 200 medium 174.32 ms 175.49 ms -1.17 ms -0.67%
Reader & Writer mixed ops 0.25 ms 0.26 ms -0.01 ms -3.85%
Reader & Writer large payloads 42.97 ms 43.43 ms -0.46 ms -1.06%
Reader & Writer 3000 small payloads 1.90 ms 1.86 ms +0.04 ms +2.15%
Reader & Writer 400 medium payloads 23.75 ms 23.45 ms +0.30 ms +1.28%
Atomic BEEF Transaction.toAtomicBEEF 1.41 ms 1.38 ms +0.03 ms +2.17%
Atomic BEEF Transaction.fromAtomicBEEF 4.36 ms 3.95 ms +0.41 ms +10.38%

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

🏁 Benchmark Comparison (Node 22)

Comparing this PR (163dfc6) against master (0b96416).

⚠️ 2 regressions detected (>5% slower).

Regressions

  • ⚠️ Reader & Writer – 3000 small payloads is 6.90% slower (1.86 ms vs 1.74 ms).
  • ⚠️ Reader & Writer – 400 medium payloads is 5.93% slower (16.79 ms vs 15.85 ms).
Benchmark Metric PR Branch Master Δ Change
BigNumber Arithmetic mul large numbers 9.01 ms 8.91 ms +0.10 ms +1.12%
BigNumber Arithmetic add large numbers 1.51 ms 1.47 ms +0.04 ms +2.72%
BigNumber Serialization toSm big 2.96 ms 2.96 ms +0.00 ms 0.00%
BigNumber Serialization toSm little 3.02 ms 3.06 ms -0.04 ms -1.31%
BigNumber Serialization fromSm big 3.06 ms 3.04 ms +0.02 ms +0.66%
BigNumber Serialization fromSm little 3.15 ms 3.17 ms -0.02 ms -0.63%
BigNumber Serialization fromScriptNum 3.15 ms 3.17 ms -0.02 ms -0.63%
Script Serialization Big script round trip 3.90 ms 3.86 ms +0.04 ms +1.04%
Transaction Verification deep chain verify 442.39 ms 445.15 ms -2.76 ms -0.62%
Transaction Verification wide transaction verify 462.76 ms 456.52 ms +6.24 ms +1.37%
Transaction Verification large tx verify 227.82 ms 226.08 ms +1.74 ms +0.77%
Transaction Verification nested inputs verify 104.45 ms 103.68 ms +0.77 ms +0.74%
Symmetric Key encrypt large 2MB 1552.80 ms 1514.51 ms +38.29 ms +2.53%
Symmetric Key decrypt large 2MB 1548.63 ms 1503.34 ms +45.29 ms +3.01%
Symmetric Key encrypt 50 small 6.70 ms 6.50 ms +0.20 ms +3.08%
Symmetric Key decrypt 50 small 6.52 ms 6.34 ms +0.18 ms +2.84%
Symmetric Key encrypt 200 medium 161.74 ms 157.16 ms +4.58 ms +2.91%
Symmetric Key decrypt 200 medium 159.09 ms 155.90 ms +3.19 ms +2.05%
Reader & Writer mixed ops 0.23 ms 0.23 ms +0.00 ms 0.00%
Reader & Writer large payloads 29.53 ms 29.34 ms +0.19 ms +0.65%
Reader & Writer 3000 small payloads 1.86 ms 1.74 ms +0.12 ms +6.90%
Reader & Writer 400 medium payloads 16.79 ms 15.85 ms +0.94 ms +5.93%
Atomic BEEF Transaction.toAtomicBEEF 1.58 ms 1.52 ms +0.06 ms +3.95%
Atomic BEEF Transaction.fromAtomicBEEF 4.19 ms 4.01 ms +0.18 ms +4.49%

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

🏁 Benchmark Comparison (Node 22)

Comparing this PR (cd22d09) against master (0b96416).

⚠️ 1 regression detected (>5% slower).

Regressions

  • ⚠️ Atomic BEEF – Transaction.fromAtomicBEEF is 10.77% slower (4.01 ms vs 3.62 ms).
Benchmark Metric PR Branch Master Δ Change
BigNumber Arithmetic mul large numbers 8.90 ms 8.86 ms +0.04 ms +0.45%
BigNumber Arithmetic add large numbers 1.46 ms 1.47 ms -0.01 ms -0.68%
BigNumber Serialization toSm big 2.89 ms 2.88 ms +0.01 ms +0.35%
BigNumber Serialization toSm little 2.94 ms 2.98 ms -0.04 ms -1.34%
BigNumber Serialization fromSm big 2.97 ms 3.03 ms -0.06 ms -1.98%
BigNumber Serialization fromSm little 3.12 ms 3.14 ms -0.02 ms -0.64%
BigNumber Serialization fromScriptNum 3.09 ms 3.10 ms -0.01 ms -0.32%
Script Serialization Big script round trip 3.84 ms 3.86 ms -0.02 ms -0.52%
Transaction Verification deep chain verify 441.68 ms 436.83 ms +4.85 ms +1.11%
Transaction Verification wide transaction verify 458.03 ms 453.38 ms +4.65 ms +1.03%
Transaction Verification large tx verify 225.00 ms 225.40 ms -0.40 ms -0.18%
Transaction Verification nested inputs verify 104.67 ms 102.82 ms +1.85 ms +1.80%
Symmetric Key encrypt large 2MB 1549.10 ms 1547.87 ms +1.23 ms +0.08%
Symmetric Key decrypt large 2MB 1544.84 ms 1546.82 ms -1.98 ms -0.13%
Symmetric Key encrypt 50 small 6.66 ms 6.71 ms -0.05 ms -0.75%
Symmetric Key decrypt 50 small 6.53 ms 6.51 ms +0.02 ms +0.31%
Symmetric Key encrypt 200 medium 161.08 ms 159.99 ms +1.09 ms +0.68%
Symmetric Key decrypt 200 medium 159.62 ms 160.43 ms -0.81 ms -0.50%
Reader & Writer mixed ops 0.22 ms 0.22 ms +0.00 ms 0.00%
Reader & Writer large payloads 28.55 ms 27.96 ms +0.59 ms +2.11%
Reader & Writer 3000 small payloads 1.73 ms 1.73 ms +0.00 ms 0.00%
Reader & Writer 400 medium payloads 14.96 ms 15.14 ms -0.18 ms -1.19%
Atomic BEEF Transaction.toAtomicBEEF 1.50 ms 1.51 ms -0.01 ms -0.66%
Atomic BEEF Transaction.fromAtomicBEEF 4.01 ms 3.62 ms +0.39 ms +10.77%

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

🏁 Benchmark Comparison (Node 22)

Comparing this PR (354c2e5) against master (0b96416).

✅ No regressions over the 5% threshold detected.

Benchmark Metric PR Branch Master Δ Change
BigNumber Arithmetic mul large numbers 8.81 ms 8.89 ms -0.08 ms -0.90%
BigNumber Arithmetic add large numbers 1.45 ms 1.46 ms -0.01 ms -0.68%
BigNumber Serialization toSm big 2.81 ms 2.81 ms +0.00 ms 0.00%
BigNumber Serialization toSm little 2.88 ms 2.94 ms -0.06 ms -2.04%
BigNumber Serialization fromSm big 3.04 ms 2.92 ms +0.12 ms +4.11%
BigNumber Serialization fromSm little 3.00 ms 3.00 ms +0.00 ms 0.00%
BigNumber Serialization fromScriptNum 3.01 ms 3.05 ms -0.04 ms -1.31%
Script Serialization Big script round trip 3.76 ms 3.77 ms -0.01 ms -0.27%
Transaction Verification deep chain verify 441.06 ms 442.17 ms -1.11 ms -0.25%
Transaction Verification wide transaction verify 453.83 ms 456.07 ms -2.24 ms -0.49%
Transaction Verification large tx verify 226.00 ms 226.47 ms -0.47 ms -0.21%
Transaction Verification nested inputs verify 103.19 ms 106.07 ms -2.88 ms -2.72%
Symmetric Key encrypt large 2MB 1503.15 ms 1552.91 ms -49.76 ms -3.20%
Symmetric Key decrypt large 2MB 1498.57 ms 1554.26 ms -55.69 ms -3.58%
Symmetric Key encrypt 50 small 6.44 ms 6.69 ms -0.25 ms -3.74%
Symmetric Key decrypt 50 small 6.29 ms 6.55 ms -0.26 ms -3.97%
Symmetric Key encrypt 200 medium 157.66 ms 162.13 ms -4.47 ms -2.76%
Symmetric Key decrypt 200 medium 153.51 ms 159.65 ms -6.14 ms -3.85%
Reader & Writer mixed ops 0.22 ms 0.22 ms +0.00 ms 0.00%
Reader & Writer large payloads 27.77 ms 27.98 ms -0.21 ms -0.75%
Reader & Writer 3000 small payloads 1.71 ms 1.69 ms +0.02 ms +1.18%
Reader & Writer 400 medium payloads 15.04 ms 14.62 ms +0.42 ms +2.87%
Atomic BEEF Transaction.toAtomicBEEF 1.50 ms 1.47 ms +0.03 ms +2.04%
Atomic BEEF Transaction.fromAtomicBEEF 3.60 ms 3.56 ms +0.04 ms +1.12%

@ty-everett ty-everett merged commit 1e0cc5c into master Dec 9, 2025
15 checks passed
@ty-everett ty-everett deleted the fix/tob-13 branch December 9, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants