Test branch #10
Merged
Test branch #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracks, Monitor not implemented?
Implemented JSON-RPC server with Django
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aligns the Python BSV Wallet Toolbox with the Go and TypeScript implementations, focusing on comprehensive testing infrastructure and API consistency.
Key Changes:
- Enhanced validation functions with additional field checks and proper error handling
- Added new utility modules for randomization, caching, and cryptographic operations
- Implemented storage entity specifications and CRUD accessors following the Go pattern
- Updated service methods to handle async operations and improve error handling
- Fixed import statements to match py-sdk API changes
Reviewed changes
Copilot reviewed 133 out of 342 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/bsv_wallet_toolbox/utils/validation.py | Expanded validation with basket/tag checks, offset validation, and new certificate/crypto validation functions |
| src/bsv_wallet_toolbox/utils/ttl_cache.py | New TTL cache implementation for pending sign actions |
| src/bsv_wallet_toolbox/utils/randomizer.py | New randomizer interface with secure and test implementations |
| src/bsv_wallet_toolbox/utils/identity_utils.py | Updated imports to match py-sdk API changes |
| src/bsv_wallet_toolbox/utils/crypto_utils.py | New cryptographic utilities for wallet operations |
| src/bsv_wallet_toolbox/utils/config.py | Added config helper functions for nested access |
| src/bsv_wallet_toolbox/utils/buffer_utils.py | Enhanced string conversion with encoding parameters |
| src/bsv_wallet_toolbox/utils/aggregate_results.py | Added result aggregation utilities |
| src/bsv_wallet_toolbox/utils/init.py | Updated exports and enhanced verify functions |
| src/bsv_wallet_toolbox/types.py | New type definitions for TSC merkle proofs |
| src/bsv_wallet_toolbox/storage/sync_processor.py | New sync chunk processor for entity synchronization |
| src/bsv_wallet_toolbox/storage/specifications.py | Complete entity DTO implementations with merge logic |
| src/bsv_wallet_toolbox/storage/provider.py | Enhanced with sync processing, basket configuration, and entity accessors |
| src/bsv_wallet_toolbox/storage/methods.py | Updated to use UTC timezone consistently |
| src/bsv_wallet_toolbox/storage/entities.py | Added from_storage_txid class method |
| src/bsv_wallet_toolbox/storage/crud.py | New CRUD entity accessors with fluent interface |
| src/bsv_wallet_toolbox/storage/create_action.py | Added duplicate outpoint validation |
| src/bsv_wallet_toolbox/storage/background_broadcaster.py | New background transaction broadcaster |
| src/bsv_wallet_toolbox/single_writer_multi_reader_lock.py | New async reader-writer lock implementation |
| src/bsv_wallet_toolbox/signer/methods.py | Updated to use UTC timezone and camelCase keys for BRC-100 compatibility |
| src/bsv_wallet_toolbox/services/wallet_services_options.py | Added service method modifier options |
| src/bsv_wallet_toolbox/services/services.py | Enhanced async support, input validation, and BEEF handling |
| src/bsv_wallet_toolbox/services/service_queue.py | New service queue for orchestration |
| src/bsv_wallet_toolbox/services/service_collection.py | Updated to use UTC timezone |
| src/bsv_wallet_toolbox/services/providers/whatsonchain.py | Enhanced error handling and async operations |
| src/bsv_wallet_toolbox/services/providers/bitails.py | Added transaction status method and UTC timezone |
| src/bsv_wallet_toolbox/services/providers/init.py | Added exchange rate provider exports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 133 out of 342 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 133 out of 342 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 133 out of 342 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jo7ueb
approved these changes
Dec 4, 2025
Collaborator
jo7ueb
left a comment
jo7ueb
left a comment
There was a problem hiding this comment.
I reviewed comment from Copilot and corresponding action.
LGTM, thank you for your work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aligns the Python BSV Wallet Toolbox with the Go and TypeScript implementations, focusing on comprehensive testing infrastructure and API consistency.
Key Changes:
Enhanced validation functions with additional field checks and proper error handling
Added new utility modules for randomization, caching, and cryptographic operations
Implemented storage entity specifications and CRUD accessors following the Go pattern
Updated service methods to handle async operations and improve error handling
Fixed import statements to match py-sdk API changes
Added comprehensive coverage testing