[Fix] - Avoid logging sensitive key material in examples #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the security of the example code and documentation for wallet and HD key generation by avoiding the exposure of sensitive key material. Instead of printing or logging raw private or public keys, the code now logs only short fingerprints derived from the public keys. The documentation is updated to reflect these best practices.
Security improvements in key handling:
create_wallet.goandgenerate_hd_key.go, added logic to compute and log only a fingerprint (first 8 bytes of a SHA-256 hash) of the public key or xPub, instead of printing the full key material. This reduces the risk of accidental key exposure. [1] [2]Documentation updates:
generate_hd_key/README.mdto instruct users not to log raw keys, to use fingerprints for verification, and to clarify the importance of keeping private keys secure. The code walkthrough and output description were also revised to match the new fingerprinting approach. [1] [2] [3]Dependency additions:
crypto/sha256import to both example files to support fingerprint generation. [1] [2]