Conform this function to match SV Node calculation #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
shruggr
approved these changes
Nov 12, 2025
kuba-4chain
reviewed
Nov 13, 2025
transaction/fee_model/sats_per_kb.go
Outdated
Comment on lines
36
to
40
| return (uint64(math.Ceil(float64(size)/1000)) * s.Satoshis), nil | ||
| return calculateFee(size, s.Satoshis), nil | ||
| } | ||
|
|
||
| func calculateFee(txSizeBytes int, satoshisPerKB uint64) uint64 { | ||
| return uint64(math.Ceil(float64(txSizeBytes) / 1000 * float64(satoshisPerKB))) |
There was a problem hiding this comment.
This changes the fee calculation. Assuming the fee rate is 100sat/KB, if the math.Ceil() is over the entire equation, it allows for the fee to be lower than 100 sats for transactions of size lower than 1 KB. If the math.Ceil() is only over the txSizeBytes / 1000, then the fee will never be lower than 100 sats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Parenthesis was just in the wrong place.
Linked Issues / Tickets
Closes #267
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
go test ./...Checklist:
CHANGELOG.mdwith my changesgolangci-lint rungo fmtandgo vetone final time before requesting a review