rework atomic testing

Author: shruggr

transaction/beef.go

@@ -5,7 +5,6 @@ import (
 	"encoding/binary"
 	"encoding/hex"
 	"fmt"
-	"io"
 
 	"github.com/bsv-blockchain/go-sdk/chainhash"
 	"github.com/bsv-blockchain/go-sdk/transaction/chaintracker"
@@ -116,19 +115,17 @@ func readBeefTx(reader *bytes.Reader, BUMPs []*MerklePath) (*map[string]*BeefTx,
 }
 
 func NewBeefFromBytes(beef []byte) (*Beef, error) {
-	reader := bytes.NewReader(beef)
+	var reader *bytes.Reader
+	if binary.LittleEndian.Uint32(beef[:4]) == ATOMIC_BEEF {
+		reader = bytes.NewReader(beef[36:])
+	} else {
+		reader = bytes.NewReader(beef)
+	}
 	version, err := readVersion(reader)
 	if err != nil {
 		return nil, err
 	}
 
-	if version == ATOMIC_BEEF {
-		reader.Seek(32, io.SeekCurrent)
-		if version, err = readVersion(reader); err != nil {
-			return nil, err
-		}
-	}
-
 	if version == BEEF_V1 {
 		BUMPs, err := readBUMPs(reader)
 		if err != nil {

transaction/beef_test.go

@@ -96,9 +96,19 @@ func TestNewBEEFFromBytes(t *testing.T) {
 	require.Len(t, beef.BUMPs, 3, "BUMPs length does not match")
 	require.Len(t, beef.Transactions, 3, "Transactions length does not match")
 
+	tx := beef.FindTransaction("b1fc0f44ba629dbdffab9e34fcc4faf9dbde3560a7365c55c26fe4daab052aac")
+	require.NotNil(t, tx, "Transaction not found in BEEF data")
+
+	atomic, err := tx.AtomicBEEF(false)
+	require.NoError(t, err, "AtomicBEEF method failed")
+
+	_, err = NewTransactionFromBEEF(atomic)
+	require.NoError(t, err, "NewTransactionFromBEEF method failed")
+
 	binary.LittleEndian.PutUint32(beefBytes[0:4], 0xdeadbeef)
 	_, err = NewTransactionFromBEEF(beefBytes)
 	require.Error(t, err, "use NewBeefFromBytes to parse anything which isn't V1 BEEF or AtomicBEEF")
+
 }
 
 func TestBeefTransactionFinding(t *testing.T) {