extraneous read

shruggr · shruggr · commit 0e57b7fe5945 · 2025-05-12T20:31:15.000-04:00
diff --git a/transaction/beef.go b/transaction/beef.go
@@ -5,6 +5,7 @@ import (
 	"encoding/binary"
 	"encoding/hex"
 	"fmt"
+	"io"
 
 	"github.com/bsv-blockchain/go-sdk/chainhash"
 	"github.com/bsv-blockchain/go-sdk/transaction/chaintracker"
@@ -122,10 +123,8 @@ func NewBeefFromBytes(beef []byte) (*Beef, error) {
 	}
 
 	if version == ATOMIC_BEEF {
-		txid := make([]byte, 32)
-		if _, err = reader.Read(txid); err != nil {
-			return nil, err
-		} else if version, err = readVersion(reader); err != nil {
+		reader.Seek(32, io.SeekCurrent)
+		if version, err = readVersion(reader); err != nil {
 			return nil, err
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ import (`
`5`	`5`	`"encoding/binary"`
`6`	`6`	`"encoding/hex"`
`7`	`7`	`"fmt"`
	`8`	`+ "io"`
`8`	`9`
`9`	`10`	`"github.com/bsv-blockchain/go-sdk/chainhash"`
`10`	`11`	`"github.com/bsv-blockchain/go-sdk/transaction/chaintracker"`
`@@ -122,10 +123,8 @@ func NewBeefFromBytes(beef []byte) (*Beef, error) {`
`122`	`123`	`}`
`123`	`124`
`124`	`125`	`if version == ATOMIC_BEEF {`
`125`		`- txid := make([]byte, 32)`
`126`		`- if _, err = reader.Read(txid); err != nil {`
`127`		`- return nil, err`
`128`		`- } else if version, err = readVersion(reader); err != nil {`
	`126`	`+ reader.Seek(32, io.SeekCurrent)`
	`127`	`+ if version, err = readVersion(reader); err != nil {`
`129`	`128`	`return nil, err`
`130`	`129`	`}`
`131`	`130`	`}`