Skip to content

Make sure bootstrap connections are maintained in DHT off mode #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrz1836 merged 1 commit into from
Nov 21, 2025
Merged

Make sure bootstrap connections are maintained in DHT off mode #20

mrz1836 merged 1 commit into from
Nov 21, 2025

Conversation

@oskarszoon
Copy link
Contributor

@oskarszoon oskarszoon commented Nov 21, 2025

What Changed

  • a 30sec ticker to maintain bootstrap server connections

Why It Was Necessary

  • needed in DHT off mode in case there are no topic peers yet and the bootstrap servers restart

@oskarszoon oskarszoon requested a review from mrz1836 as a code owner November 21, 2025 12:56
@github-actions github-actions bot added size/S Small change (11–50 lines) bug-P3 Lowest rated bug, affects nearly none or low-impact labels Nov 21, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mrz1836
mrz1836 approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrz1836 mrz1836 added the feature Any new significant addition label Nov 21, 2025
@mrz1836 mrz1836 merged commit 42b974a into main Nov 21, 2025
50 checks passed
@github-actions github-actions bot deleted the bugfix/dht-off-bootstrap-connections branch November 21, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrz1836 mrz1836 mrz1836 approved these changes

@galt-tr galt-tr galt-tr approved these changes

Assignees

@mrz1836 mrz1836

Labels

bug-P3 Lowest rated bug, affects nearly none or low-impact feature Any new significant addition size/S Small change (11–50 lines)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oskarszoon @mrz1836 @galt-tr