test(client): replace hardcoded strings with constants in tests

Author: mrz1836

client_messaging_test.go

@@ -9,6 +9,8 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+const testData = "test data"
+
 func TestClientSubscribeMultipleTopicsConcurrently(t *testing.T) {
 	privKey, err := GeneratePrivateKey()
 	require.NoError(t, err)
@@ -66,7 +68,7 @@ func TestClientPublishToUnsubscribedTopic(t *testing.T) {
 	ctx := context.Background()
 
 	// Publish to a topic we haven't subscribed to
-	err = cl.Publish(ctx, "new-topic", []byte("test data"))
+	err = cl.Publish(ctx, "new-topic", []byte(testData))
 	require.NoError(t, err)
 }
 
@@ -274,14 +276,14 @@ func TestMessageStructFields(t *testing.T) {
 		Topic:     "test-topic",
 		From:      "test-peer",
 		FromID:    "12D3KooTest",
-		Data:      []byte("test data"),
+		Data:      []byte(testData),
 		Timestamp: time.Now(),
 	}
 
 	assert.Equal(t, "test-topic", msg.Topic)
 	assert.Equal(t, "test-peer", msg.From)
 	assert.Equal(t, "12D3KooTest", msg.FromID)
-	assert.Equal(t, []byte("test data"), msg.Data)
+	assert.Equal(t, []byte(testData), msg.Data)
 	assert.False(t, msg.Timestamp.IsZero())
 }
 

client_peers_test.go

@@ -32,7 +32,7 @@ func TestClientGetPeersWithTopicPeers(t *testing.T) {
 	assert.Empty(t, peers)
 
 	// Subscribe to a topic
-	_ = client1.Subscribe("test-topic")
+	_ = client1.Subscribe(testTopicName)
 
 	// Give subscription time to initialize
 	time.Sleep(100 * time.Millisecond)
@@ -110,7 +110,7 @@ func TestClientSavePeerCacheEnabled(t *testing.T) {
 	c := cl.(*client)
 
 	// Subscribe to a topic to initialize topics map
-	_ = c.Subscribe("test-topic")
+	_ = c.Subscribe(testTopicName)
 	time.Sleep(100 * time.Millisecond)
 
 	// Call savePeerCache
@@ -143,7 +143,7 @@ func TestClientSavePeerCacheWithInvalidPath(t *testing.T) {
 	c := cl.(*client)
 
 	// Subscribe to a topic
-	_ = c.Subscribe("test-topic")
+	_ = c.Subscribe(testTopicName)
 	time.Sleep(50 * time.Millisecond)
 
 	// Should not panic even with invalid path
@@ -231,7 +231,7 @@ func TestClientSavePeerCacheMergesExistingData(t *testing.T) {
 	c := cl.(*client)
 
 	// Subscribe to trigger topic creation
-	_ = c.Subscribe("test-topic")
+	_ = c.Subscribe(testTopicName)
 	time.Sleep(50 * time.Millisecond)
 
 	// Save cache

client_test.go

@@ -603,7 +603,9 @@ func TestBuildHostOptionsWithAnnounceAddrs(t *testing.T) {
 	logger := &DefaultLogger{}
 	// noop cancel function for testing - buildHostOptions requires a cancel function
 	// but we don't need actual cancellation logic in this unit test
-	cancel := func() {}
+	cancel := func() {
+		// Intentionally empty - this is a test fixture that satisfies the function signature
+	}
 
 	tests := []struct {
 		name          string