test(client): refactor relay peer multiaddr usage in tests

Author: mrz1836

client_additional_test.go

@@ -9,6 +9,8 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+const testRelayPeerMultiaddr = "/ip4/127.0.0.1/tcp/4001/p2p/QmYyQSo1c1Ym7orWxLYvCrM2EmxFTANf8wXmmE7DWjhx5N"
+
 func TestNewClientWithCustomRelayPeers(t *testing.T) {
 	tests := []struct {
 		name       string
@@ -18,7 +20,7 @@ func TestNewClientWithCustomRelayPeers(t *testing.T) {
 		{
 			name: "single relay peer",
 			relayPeers: []string{
-				"/ip4/127.0.0.1/tcp/4001/p2p/QmYyQSo1c1Ym7orWxLYvCrM2EmxFTANf8wXmmE7DWjhx5N",
+				testRelayPeerMultiaddr,
 			},
 			wantErr: false,
 		},
@@ -66,7 +68,7 @@ func TestConfigureRelayPeersWithValidPeers(t *testing.T) {
 
 	// Valid relay peer
 	relayPeersConfig := []string{
-		"/ip4/127.0.0.1/tcp/4001/p2p/QmYyQSo1c1Ym7orWxLYvCrM2EmxFTANf8wXmmE7DWjhx5N",
+		testRelayPeerMultiaddr,
 	}
 
 	relayPeers := configureRelayPeers(relayPeersConfig, bootstrapPeers, logger)
@@ -80,7 +82,7 @@ func TestConfigureRelayPeersWithMixedValidity(t *testing.T) {
 
 	// Mix of valid and invalid
 	relayPeersConfig := []string{
-		"/ip4/127.0.0.1/tcp/4001/p2p/QmYyQSo1c1Ym7orWxLYvCrM2EmxFTANf8wXmmE7DWjhx5N",
+		testRelayPeerMultiaddr,
 		"invalid-peer",
 	}
 

client_edge_cases_test.go

@@ -9,6 +9,8 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+const testMessagingTopic = "messaging-test"
+
 func TestClientTwoWayMessaging(t *testing.T) {
 	// Create two clients
 	privKey1, err := GeneratePrivateKey()
@@ -42,16 +44,16 @@ func TestClientTwoWayMessaging(t *testing.T) {
 	}()
 
 	// Subscribe to same topic
-	msgChan1 := cl1.Subscribe("messaging-test")
-	msgChan2 := cl2.Subscribe("messaging-test")
+	msgChan1 := cl1.Subscribe(testMessagingTopic)
+	msgChan2 := cl2.Subscribe(testMessagingTopic)
 
 	// Give time for subscriptions and discovery
 	time.Sleep(3 * time.Second)
 
 	// Publish from client1
 	ctx := context.Background()
 	testData := []byte("Hello from client1")
-	err = cl1.Publish(ctx, "messaging-test", testData)
+	err = cl1.Publish(ctx, testMessagingTopic, testData)
 	require.NoError(t, err)
 
 	// Try to receive on both clients (one should get it, the sender filters itself)

client_helpers_test.go

@@ -12,6 +12,8 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+const testLocalMultiaddr = "/ip4/127.0.0.1/tcp/4001"
+
 func TestParseMultiaddrs(t *testing.T) {
 	tests := []struct {
 		name          string
@@ -21,7 +23,7 @@ func TestParseMultiaddrs(t *testing.T) {
 	}{
 		{
 			name:          "valid multiaddrs",
-			addrs:         []string{"/ip4/127.0.0.1/tcp/4001", "/ip6/::1/tcp/4001"},
+			addrs:         []string{testLocalMultiaddr, "/ip6/::1/tcp/4001"},
 			expectedCount: 2,
 			description:   "valid multiaddrs should be parsed successfully",
 		},
@@ -51,7 +53,7 @@ func TestParseMultiaddrs(t *testing.T) {
 		},
 		{
 			name:          "mixed valid and invalid",
-			addrs:         []string{"/ip4/127.0.0.1/tcp/4001", "invalid", "/ip6/::1/tcp/4001"},
+			addrs:         []string{testLocalMultiaddr, "invalid", "/ip6/::1/tcp/4001"},
 			expectedCount: 2,
 			description:   "only valid multiaddrs should be included",
 		},
@@ -105,7 +107,7 @@ func TestConnectToCachedPeers(t *testing.T) {
 					{
 						ID:    "invalid-peer-id",
 						Name:  "test",
-						Addrs: []string{"/ip4/127.0.0.1/tcp/4001"},
+						Addrs: []string{testLocalMultiaddr},
 					},
 				}
 			},