Fixes issue #6: Broken test_sortkeys() plus other updates. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer python dictionaries are keeping the order the keys were added in. As a result since both lists were pre-sorted and identicle so the later test failed to find any expected differences causing the failure. This change introduces 3 entries that are out of sorted order for both the obytes and xbytes lists. This ensures a valid test of sorting.
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Aug 29, 2022
Also backports a fix for tests [1] See: https://wiki.archlinux.org/index.php?title=Python_package_guidelines&type=revision&diff=743435&oldid=742361 See: pypa/distutils#133 [1] brianolson/cbor_py#19 git-svn-id: file:///srv/repos/svn-community/svn@1285262 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Aug 29, 2022
Also backports a fix for tests [1] See: https://wiki.archlinux.org/index.php?title=Python_package_guidelines&type=revision&diff=743435&oldid=742361 See: pypa/distutils#133 [1] brianolson/cbor_py#19 git-svn-id: file:///srv/repos/svn-community/svn@1285262 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken test_sortkeys() issue #6
Adds cbor/tests to packages for proper installation testing.
Adds python 3.6, 3.7, 3.8 to setup.py (tested, passing)
Replaces deprecated logger.warn() calls