Skip to content

Conversation

@slavastartsev
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Dec 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
bob-docs Ready Ready Preview Comment Dec 9, 2025 9:18pm

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @slavastartsev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on expanding the project's token support by integrating the BNB token across key blockchain networks, specifically Ethereum and BNB Smart Chain. The changes include adding comprehensive metadata and visual assets for BNB, alongside a crucial correction to prevent misidentification of ETH on BNB Smart Chain. This ensures that applications consuming these token lists will have accurate and up-to-date information for BNB.

Highlights

  • BNB Token Integration: Added support for the BNB token on both Ethereum (chainId 1) and BNB Smart Chain (chainId 56) to the token lists.
  • New BNB Assets: Introduced new data files (data.json) and SVG logo files (logo.svg) specifically for the BNB token.
  • Token List Refinement: Corrected an erroneous entry in the token lists where Ether (ETH) on BNB Smart Chain was incorrectly listed and overridden as BNB, ensuring accurate token representation.
  • Timestamp Updates: Updated the timestamp field across multiple token list JSON files to reflect the recent changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@slavastartsev slavastartsev changed the title chore: add bnb chore: update swaps client interfaces Dec 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the token list to add BNB as a distinct token, separating it from the previous ETH-based workaround. This includes adding a new data file for BNB and updating the main token lists. However, there is a critical issue with the new BNB logo file, which currently contains the Ethereum logo. This needs to be fixed to avoid user confusion.

Comment on lines 1 to 13
<svg xmlns="http://www.w3.org/2000/svg" width="2500" height="2500" viewBox="0 0 32 32">
<g fill="none" fill-rule="evenodd">
<circle cx="16" cy="16" r="16" fill="#627EEA"/>
<g fill="#FFF" fill-rule="nonzero">
<path fill-opacity=".602" d="M16.498 4v8.87l7.497 3.35z"/>
<path d="M16.498 4L9 16.22l7.498-3.35z"/>
<path fill-opacity=".602" d="M16.498 21.968v6.027L24 17.616z"/>
<path d="M16.498 27.995v-6.028L9 17.616z"/>
<path fill-opacity=".2" d="M16.498 20.573l7.497-4.353-7.497-3.348z"/>
<path fill-opacity=".602" d="M9 16.22l7.498 4.353v-7.701z"/>
</g>
</g>
</svg> No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The provided SVG file for the BNB logo is incorrect. It actually contains the logo for Ethereum. This is evident from:

  • The fill color #627EEA, which is Ethereum's brand color. BNB's color is typically yellow/gold (e.g., #F0B90B).
  • The <path> data, which draws the Ethereum octahedron shape, not the BNB diamond.

Using the wrong logo can be very misleading for users. Please replace this with the correct SVG for the BNB token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants