feat(crypto): restore ripemd160, sha1 and sha256 hash helpers #2248
+57
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Armss9936
approved these changes
Jul 24, 2025
Member
Author
|
CI is red due to a GitHub Actions cache hiccup: All unit + integration tests pass locally. The same 400 cache issue showed up in #2247. I’m digging into it... |
Member
|
Good work. Re: CI changes, pin the commits to the v4 branch so we don't have to spend mental capacity weighing the options of changing pinning/no-pinning. Default is that maintainers can modify PR branches, so you can go to their fork and edit that branch directly with a commit via the web UI if you want. |
landabaso
force-pushed
the
feat/restore-hash-helpers
branch
from
074f0ad to
48d1e53
Compare
Member
Author
junderw
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Several downstream projects still rely on the simple hash helpers removed during the v7 refactor. Bringing them back avoids extra boilerplate and keeps parity with previous majors while we're still in RC.
What
ripemd160,sha1andsha256helpers tocrypto.test/crypto.spec.ts,test/fixtures/crypto.json).Breaking changes?
None. Existing code keeps working.