Skip to content

Conversation

@rustaceanrob
Copy link
Collaborator

@rustaceanrob rustaceanrob commented Dec 2, 2025

For users recovering an old wallet, it is best to used the pre-defined points like segwit or taproot; however, new users that have definitely not used their descriptor may be caught off guard if they have to wait for their wallet to sync for more than a couple seconds. This change allows for a recovery from any hash and height, with the idea being the developer can provide a recent block via a service like mempool(dot)space

@andreasgriffin

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added a changelog in the next release tracking issue (see example)
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

For users recovering an old wallet, it is best to used the pre-defined
points like segwit or taproot; however, new users that have definitely
not used their descriptor may be caught off guard if they have to wait
for their wallet to sync for more than a couple seconds. This change
allows for a recovery from any hash and height, with the idea being the
developer can provide a recent block via a service like
mempool(dot)space
Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 677a60e

Note: did not test locally built bindings

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 677a60e.

@thunderbiscuit thunderbiscuit merged commit 677a60e into bitcoindevkit:master Dec 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants