-
Notifications
You must be signed in to change notification settings - Fork 98
feat: Support 16KB page size for Android 15+ #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…rate pubspec.lock
Summary of ChangesHello @JoelOvien, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request proactively addresses an upcoming compatibility requirement for Android 15 and subsequent versions. By updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the flutter_pdfview dependency to a beta version to add support for 16KB page sizes on Android 15. The change is straightforward and necessary to ensure compatibility with the upcoming Android version. My feedback includes a suggestion to consider publishing this package as a pre-release version to reflect its dependency on a beta package, which is a good practice for managing user expectations about stability.
|
@JoelOvien flutter_pdfview now supports 16kb pages with version 1.4.3 :) |
Thanks @dbenedictos, I have now updated the version |
|
Just curious, how are you checking if this package is in alignment? I'm using the script found here, https://developer.android.com/guide/practices/page-sizes#alignment-use-script and running it for my app after making changes to the pubspec, cleaning, getting, and then rebuilding. The output after doing a dependency override to 1.4.3 for flutter_pdfview shows the following When removing the package that depends on flutter_pdfview and its usage within my app, I get a clean output. |
Actually, I'm guessing this is fine since in the script it states "only arm64-v8a/x86_64 libs need to be aligned". Running the Build APK Analyzer on the release shows all libs in alignment, even the armeabi-v7a. Also, I don't see the 16KB warning when running my app.
|
In my experience. I ran the apk analyzer tool in android studio after updating all packages to their latest resolvable version. The tool said that all my packages are 16kb compatible but, when running the app on a 16kb simulator. I still get the incompatible warning. I manually eliminated packages to see what was the culprit and I concluded that it was the flutter_cached_pdfview -> flutter_pdfview |

Description
This PR updates the
flutter_pdfviewdependency to version1.4.2-beta.1to add support for 16KB page sizes on Android 15 and higher.Problem
With the upcoming changes in Android 15, applications are required to support 16KB page sizes. The native libraries (
.sofiles) included in previous versions offlutter_pdfviewwere built with a 4KB page size, causing compatibility issues for applications targeting the new Android version.Solution
This pull request resolves the issue by updating the
flutter_pdfviewdependency to1.4.2-beta.1. This version of the dependency includes updated native libraries that are aligned with the 16KB page size requirement.