Upgrade Bzlmod examples to Bazel 9.* #648
Open
+38
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update .bazelversion to 9.* for all Bzlmod examples - Replace incompatible glog with abseil-cpp/iostream in 01 and 02 - Verify all builds pass with Bazel 9.0.0rc3
- Use abseil-cpp for archive_override - Use re2 for git_override - This restores the override examples while ensuring compatibility with Bazel 9
Wyverald
reviewed
Dec 17, 2025
|
|
||
| bazel_dep(name = "rules_cc", version = "0.0.17") | ||
|
|
||
| # 1. The metadata of glog is fetched from the BCR, including its dependencies (gflags). |
Member
There was a problem hiding this comment.
please update this comment (s/glog/abseil-cpp/; no repo_name; also I'm not sure if abseil-cpp has transitive deps?)
| # gflag is still an indirect dependency, the override itself doesn't give the root module visibility on gflags. | ||
| # Override re2 to a specific commit with git_override. | ||
| # This demonstrates how to use git_override to depend on a specific commit. | ||
| bazel_dep(name = "re2", version = "2024-07-02", repo_name = "com_googlesource_re2") |
Member
There was a problem hiding this comment.
restore the previous comment, and also remove this bazel_dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update .bazelversion to 9.* for all Bzlmod examples to verify compatibility with Bazel 9 release candidates.
Changes:
.bazelversionto9.*in all 6 Bzlmod examples.glogwithabseil-cppandiostreamdue toglogincompatibility with Bazel 9.glog/gflagsoverrides withabseil-cpp(archive_override) andre2(git_override) to demonstrate override capabilities with Bazel 9 compatible libraries.