Skip to content

Commit 48384b7

Browse files
authored
Update parameter binding data to provide ConnectionName (Azure#38284)
* Update parameter binding data to provide ConnectionName * Update CreateParameterBindingData to set default * set default to AzureWebJobsStorage * fix ref
1 parent 5a5adff commit 48384b7

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Release History
22

33
## 5.2.0 (2023-08-10)
4+
- Updating ParameterBindingData "Connection" value to the full connection name instead of the connection section key
45

56
### Features Added
67
- Added support for `BlobsOptions.PoisonBlobThreshold`

sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,17 +231,21 @@ private ParameterBindingData ConvertToParameterBindingData(BlobBaseClient input,
231231

232232
private ParameterBindingData ConvertBlobInputToParameterBindingData(BlobBaseClient input)
233233
{
234-
return CreateParameterBindingData(null, input.Name, input.BlobContainerName);
234+
return CreateParameterBindingData(string.Empty, input.Name, input.BlobContainerName);
235235
}
236236

237237
private ParameterBindingData CreateParameterBindingData(string connection, string blobName, string containerName)
238238
{
239-
string connectionName = !string.IsNullOrEmpty(connection) ? _nameResolver.ResolveWholeString(connection) : string.Empty;
240-
var connectionSection = _blobServiceClientProvider.GetWebJobsConnectionStringSection(connectionName);
239+
string connectionName = _nameResolver.ResolveWholeString(connection);
240+
241+
if (string.IsNullOrWhiteSpace(connectionName))
242+
{
243+
connectionName = Constants.AzureWebJobsStorage; // default
244+
}
241245

242246
var blobDetails = new BlobParameterBindingDataContent()
243247
{
244-
Connection = connectionSection.Key,
248+
Connection = connectionName,
245249
BlobName = blobName,
246250
ContainerName = containerName
247251
};

sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Common/src/Shared/Constants.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,6 @@ internal static class Constants
88
public const string DateTimeFormatString = "yyyy'-'MM'-'dd'T'HH':'mm':'ss'.'fffK";
99
public const string WebJobsBlobExtensionName = "AzureStorageBlobs";
1010
public const string WebJobsQueueExtensionName = "AzureStorageQueues";
11+
public const string AzureWebJobsStorage = "AzureWebJobsStorage";
1112
}
1213
}

0 commit comments

Comments
 (0)