Skip to content

Commit 5a5adff

Browse files
authored
Made AddAzureStorageBlobsScaleForTrigger from public to internal temporarily (Azure#38327)
1 parent 0acc039 commit 5a5adff

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/api/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs.netstandard2.0.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,5 @@ namespace Microsoft.Extensions.Hosting
5454
public static partial class StorageBlobsWebJobsBuilderExtensions
5555
{
5656
public static Microsoft.Azure.WebJobs.IWebJobsBuilder AddAzureStorageBlobs(this Microsoft.Azure.WebJobs.IWebJobsBuilder builder, System.Action<Microsoft.Azure.WebJobs.Host.BlobsOptions> configureBlobs = null) { throw null; }
57-
public static Microsoft.Azure.WebJobs.IWebJobsBuilder AddAzureStorageBlobsScaleForTrigger(this Microsoft.Azure.WebJobs.IWebJobsBuilder builder, Microsoft.Azure.WebJobs.Host.Scale.TriggerMetadata triggerMetadata) { throw null; }
5857
}
5958
}

sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs.csproj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
44
</PropertyGroup>
55
<PropertyGroup>
66
<Version>5.2.0</Version>
77
<!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
88
<ApiCompatVersion>5.1.3</ApiCompatVersion>
9-
<Description>This extension adds bindings for Storage</Description>
9+
<RunApiCompat>false</RunApiCompat>
10+
<Description>This extension adds bindings for Storage</Description>
1011
<!-- https://github.com/Azure/azure-sdk-for-net/issues/19222 -->
1112
<NoWarn>$(NoWarn);IDT002;IDT003</NoWarn>
1213
</PropertyGroup>

sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/StorageBlobsWebJobsBuilderExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public static IWebJobsBuilder AddAzureStorageBlobs(this IWebJobsBuilder builder,
7171
/// <param name="builder"></param>
7272
/// <param name="triggerMetadata">Trigger metadata.</param>
7373
/// <returns></returns>
74-
public static IWebJobsBuilder AddAzureStorageBlobsScaleForTrigger(this IWebJobsBuilder builder, TriggerMetadata triggerMetadata)
74+
internal static IWebJobsBuilder AddAzureStorageBlobsScaleForTrigger(this IWebJobsBuilder builder, TriggerMetadata triggerMetadata)
7575
{
7676
builder.Services.AddSingleton<IScaleMonitorProvider>(serviceProvider =>
7777
{

sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Scenario.Tests/tests/BlobScaleHostEndToEndTests.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class BlobScaleHostEndToEndTests : LiveTestBase<WebJobsTestEnvironment>
3333

3434
private const string Function1Name = "Function1";
3535

36-
private string ContainerNameTemaplte1 = "container1%rnd%";
36+
//private string ContainerNameTemaplte1 = "container1%rnd%";
3737

3838
private const string BlobConnection1 = "BlobConnection1";
3939

@@ -44,6 +44,7 @@ public void SetUp()
4444
_blobServiceClient = _fixture.BlobServiceClient;
4545
}
4646

47+
/* TODO: https://github.com/Azure/azure-sdk-for-net/issues/38326 renable test after AddAzureStorageBlobsScaleForTrigger is added back.
4748
[Test]
4849
[TestCase(true, Ignore = "true", IgnoreReason = "The test can take long time.")]
4950
[TestCase(false)]
@@ -66,7 +67,7 @@ public async Task BlobScaleHostEndToEndTest(bool writeBlob)
6667
}";
6768
6869
string triggers = $@"{{
69-
""triggers"": [
70+
""triggers"": [
7071
{{
7172
""name"": ""myQueueItem"",
7273
""type"": ""queueTrigger"",
@@ -75,7 +76,7 @@ public async Task BlobScaleHostEndToEndTest(bool writeBlob)
7576
""connection"": ""{BlobConnection1}"",
7677
""functionName"": ""{Function1Name}""
7778
}}
78-
]}}";
79+
]}}";
7980
8081
IHost host = new HostBuilder().ConfigureServices(services => services.AddAzureClientsCore()).Build();
8182
AzureComponentFactory defaultAzureComponentFactory = host.Services.GetService<AzureComponentFactory>();
@@ -176,6 +177,7 @@ await TestHelpers.Await(async () =>
176177
return scaleStatus.Vote == ScaleVote.None && scaleStatus.FunctionScaleStatuses[Function1Name].Vote == ScaleVote.None;
177178
}, timeout);
178179
}
180+
*/
179181

180182
private void SetRecentWrite(IHost scaleHost, BlobContainerClient blobContainerClient, bool setValue)
181183
{

0 commit comments

Comments
 (0)