Skip to content

Conversation

@halx99
Copy link
Collaborator

@halx99 halx99 commented Nov 12, 2025

Describe your changes

  • vulkan RHI
  • axslcc to 3.0.0
  • enable glad vulkan support
  • fix stencil manager verteices data
  • refactor android jni and java surface class
  • rename internal class name: CommandBuffer => RenderContext
  • Add tools/cmdline/shaderu.ps1 to upgrade exists shader to adapt vulkan RHI feature requirements

all shaders need migrate by axmol/tools/cmdline/spirv-fix.ps

Target platforms

  • Windows
  • Linux

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

@halx99
Copy link
Collaborator Author

halx99 commented Nov 12, 2025

/clang-format

@axmol-bot
Copy link
Collaborator

👋 @halx99 Command /clang-format received. Running code formatting, please wait...

@axmol-bot
Copy link
Collaborator

✅ Formatting completed and changes have been committed to the PR branch: wip-vulkan.
@halx99 please refresh to see the latest code.

@aismann
Copy link
Contributor

aismann commented Nov 12, 2025

@halx99
I belive vulkan have to have also an own build (win-vulkan) like:
win32-ogl, win32-d3d11, ...

@halx99
Copy link
Collaborator Author

halx99 commented Nov 12, 2025

@halx99 I belive vulkan have to have also an own build (win-vulkan) like: win32-ogl, win32-d3d11, ...

Yes, but not current, because there are still lots of work to do, current only beginFrame, endFrame, clearColor works

@halx99 halx99 force-pushed the wip-vulkan branch 2 times, most recently from 3fb6dc3 to 24039f3 Compare November 12, 2025 11:19
@halx99
Copy link
Collaborator Author

halx99 commented Nov 13, 2025

image

@halx99 halx99 added this to the 3.0.0 milestone Nov 13, 2025
@paulocoutinhox
Copy link
Contributor

Wow, nice. What is the advantage of have Vulkan support? Thanks.

@halx99
Copy link
Collaborator Author

halx99 commented Nov 13, 2025

/clang-format

@axmol-bot
Copy link
Collaborator

👋 @halx99 Command /clang-format received. Running code formatting, please wait...

@axmol-bot
Copy link
Collaborator

✅ Formatting completed and changes have been committed to the PR branch: wip-vulkan.
@halx99 please refresh to see the latest code.

@halx99 halx99 changed the title WIP: Implement vulkan renderer backend WIP: Implement vulkan RHI Nov 13, 2025
@halx99 halx99 modified the milestones: 3.0.0, 2.10.0, 3.1.0 Nov 13, 2025
@halx99
Copy link
Collaborator Author

halx99 commented Nov 16, 2025

/clang-format

@axmol-bot
Copy link
Collaborator

👋 @halx99 Command /clang-format received. Running code formatting, please wait...

@axmol-bot
Copy link
Collaborator

✅ Formatting completed and changes have been committed to the PR branch: wip-vulkan.
@halx99 please refresh to see the latest code.

@halx99 halx99 marked this pull request as ready for review November 19, 2025 11:34
@halx99
Copy link
Collaborator Author

halx99 commented Nov 19, 2025

/clang-format

@axmol-bot
Copy link
Collaborator

👋 @halx99 Command /clang-format received. Running code formatting, please wait...

@axmol-bot
Copy link
Collaborator

✅ Formatting completed and changes have been committed to the PR branch: wip-vulkan.
@halx99 please refresh to see the latest code.

@aismann
Copy link
Contributor

aismann commented Nov 19, 2025

@halx99 I belive vulkan have to have also an own build (win-vulkan) like: win32-ogl, win32-d3d11, ...

Yes, but not current, because there are still lots of work to do, current only beginFrame, endFrame, clearColor works

Maybe time to add the vulkan build?
=> Easier for testing etc...

@aismann
Copy link
Contributor

aismann commented Nov 20, 2025

Please rename the artifact its has the same name like windows_d3d11_x64.zip
Anyway: it seems vulkan is the fastest rendering pipeline (on windows) now.

- Changed acquire semaphores allocation to match swapchain image count
- Avoids reuse timing issues on certain Android GPU drivers
- Improves frame stability and reduces random flickering during acquire/present
@aismann
Copy link
Contributor

aismann commented Nov 20, 2025

As far as Im can see:
Only the artifact section is done for VK (all others removed?)
image

At least D3D11 is missed
image

@aismann
Copy link
Contributor

aismann commented Nov 20, 2025

cpp-tests: autotest (windows) runs without any error!
Great work!

@aismann
Copy link
Contributor

aismann commented Nov 20, 2025

@halx99
artefact: windows_ogl_x64 is starting but closed fast (not working for me)

@halx99 halx99 changed the title WIP: Implement vulkan RHI Implement vulkan RHI Nov 20, 2025
@aismann
Copy link
Contributor

aismann commented Nov 20, 2025

@halx99
windows_ogl_x64 is still not starting (only the cmd is shown for few millisec)

@halx99 halx99 merged commit 411b913 into dev Nov 21, 2025
47 of 63 checks passed
@halx99 halx99 deleted the wip-vulkan branch November 21, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking changes enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants