-
Notifications
You must be signed in to change notification settings - Fork 368
Dual-Stack Endpoints Support #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v1.12.1
Are you sure you want to change the base?
Conversation
|
Important Remember to revert Producer C SDK tag before merging! |
samples/Common.c
Outdated
| } | ||
| #endif | ||
|
|
||
| if(pCreateSampleConfigurationParams->useDualStackEndpoints) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would suggest adding an override for the endpoint for testing in pre-prod (eg via env)
|
This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one. |
Issue #, if available:
N/A
What was changed?
createSampleConfigurationfunction's parameters, including the newuseDualStackEndpointsparameter, into a single struct to avoid excessively long function signature.Note
The name for this new
useDualStackEndpointsparameter is plural because using the dual-stack Control Plane endpoint (once it is ready) will result in a dual-stack signaling channel server endpoint which will result in dual-stack TURN server URIs. It also will likely control legacy/dual-stack of the KVS STUN server endpoint that is also constructed in the application.Why was it changed?
How was it changed?
MAX_CONTROL_PLANE_URI_CHAR_LENinto a public header file for the application to access it.What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.