Initialize framework and framework version in post_init #5424
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviruthen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
aviruthen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
| self.inference_recommender_job_results = None | ||
| self.container_log_level = logging.INFO | ||
|
|
||
| if not hasattr(self, 'framework') or self.framework is None: |
Collaborator
There was a problem hiding this comment.
Do we need the or self.framework is None here?
Collaborator
Author
There was a problem hiding this comment.
Oh yes I guess not... it doesn't change the logic but for simplicity I can make this change!
aviruthen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
aviruthen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
aviruthen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Collaborator
Author
Sagemaker-serve tests passing except for one
|
aviruthen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
aviruthen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#5391
Description of changes:
Fix a bug to initialize framework and framework version during post_init to None by default. Update model registry notebook.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.