chore(codegen): normalize enum generation #7528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
Removes the AWS codegen customization that stripped names from a list of older enums.
Context
The justification for the customization no longer applies in the current state of the codegen application.
The only enums affected were those in client-accessanalyzer because they were the only string+EnumTrait enums. The others were all enum shapes to begin with, leaving no codegen diff.
Further, the change is in fact entirely backwards compatible under our new enum scheme, and it has been years since we changed from TS enums to const objects w/ type overloads.
The type that is now exported is identical to the old exported type, and in addition an enum object is now exported, making these enums consistent with all our other enums by having a runtime representation.
Testing
CI