Skip to content

Conversation

@kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 26, 2025

Issue

n/a

Description

Removes the AWS codegen customization that stripped names from a list of older enums.

Context

The justification for the customization no longer applies in the current state of the codegen application.

Strips enum names from enums that GA'd without them.

A number of enums had names back-filled after GA. Since the type generated would change,
this is backwards-incompatible. This integration ensures that clients generated
preserve backwards-compatibility by stripping names from enums that were known to have
launched without them.

The only enums affected were those in client-accessanalyzer because they were the only string+EnumTrait enums. The others were all enum shapes to begin with, leaving no codegen diff.

Further, the change is in fact entirely backwards compatible under our new enum scheme, and it has been years since we changed from TS enums to const objects w/ type overloads.

The type that is now exported is identical to the old exported type, and in addition an enum object is now exported, making these enums consistent with all our other enums by having a runtime representation.

  • I visually inspected all the enums and their new type values are identical to their old type values.

Testing

CI

@kuhe kuhe requested a review from a team as a code owner November 26, 2025 18:21
@kuhe kuhe marked this pull request as draft November 26, 2025 19:06
@kuhe kuhe marked this pull request as ready for review November 26, 2025 19:06
@kuhe kuhe merged commit 0ed8618 into main Nov 26, 2025
8 checks passed
@kuhe kuhe deleted the chore/enums branch November 26, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants