Skip to content

feat: release telemetry #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: release telemetry #969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...li-integ/tests/telemetry-integ-tests/cdk-cli-telemetry-disable-sends-no-data.integtest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import { TELEMETRY_ENDPOINT } from './constants';
import { integTest, withDefaultFixture } from '../../lib';

jest.setTimeout(2 * 60 * 60_000); // Includes the time to acquire locks, worst-case single-threaded runtime

integTest(
'CLI Telemetry --disable does not send to endpoint',
withDefaultFixture(async (fixture) => {
const output = await fixture.cdk(['cli-telemetry', '--disable'], { verboseLevel: 3, modEnv: { TELEMETRY_ENDPOINT: TELEMETRY_ENDPOINT } });
const output = await fixture.cdk(['cli-telemetry', '--disable'], { verboseLevel: 3 });

// Check the trace that telemetry was not executed successfully
expect(output).not.toContain('Telemetry Sent Successfully');
Expand Down
2 changes: 0 additions & 2 deletions .../@aws-cdk-testing/cli-integ/tests/telemetry-integ-tests/cdk-deploy-telemetry.integtest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import * as path from 'path';
import * as fs from 'fs-extra';
import { TELEMETRY_ENDPOINT } from './constants';
import { integTest, withDefaultFixture } from '../../lib';

jest.setTimeout(2 * 60 * 60_000); // Includes the time to acquire locks, worst-case single-threaded runtime
Expand All @@ -14,7 +13,6 @@ integTest(
const deployOutput = await fixture.cdkDeploy('test-1', {
telemetryFile,
verboseLevel: 3, // trace mode
modEnv: { TELEMETRY_ENDPOINT: TELEMETRY_ENDPOINT },
});

// Check the trace that telemetry was executed successfully
Expand Down
2 changes: 0 additions & 2 deletions ...esting/cli-integ/tests/telemetry-integ-tests/cdk-synth-telemetry-with-errors.integtest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import * as path from 'path';
import * as fs from 'fs-extra';
import { TELEMETRY_ENDPOINT } from './constants';
import { integTest, withDefaultFixture } from '../../lib';

jest.setTimeout(2 * 60 * 60_000); // Includes the time to acquire locks, worst-case single-threaded runtime
Expand All @@ -13,7 +12,6 @@ integTest(
allowErrExit: true,
modEnv: {
INTEG_STACK_SET: 'stage-with-errors',
TELEMETRY_ENDPOINT: TELEMETRY_ENDPOINT,
},
verboseLevel: 3, // trace mode
});
Expand Down
3 changes: 1 addition & 2 deletions ...s/@aws-cdk-testing/cli-integ/tests/telemetry-integ-tests/cdk-synth-telemetry.integtest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import * as path from 'path';
import * as fs from 'fs-extra';
import { TELEMETRY_ENDPOINT } from './constants';
import { integTest, withDefaultFixture } from '../../lib';

jest.setTimeout(2 * 60 * 60_000); // Includes the time to acquire locks, worst-case single-threaded runtime
Expand All @@ -12,7 +11,7 @@ integTest(

const synthOutput = await fixture.cdk(
['synth', fixture.fullStackName('test-1'), '--unstable=telemetry', `--telemetry-file=${telemetryFile}`],
{ modEnv: { TELEMETRY_ENDPOINT: TELEMETRY_ENDPOINT }, verboseLevel: 3 }, // trace mode
{ verboseLevel: 3 }, // trace mode
);

// Check the trace that telemetry was executed successfully
Expand Down
1 change: 0 additions & 1 deletion packages/@aws-cdk-testing/cli-integ/tests/telemetry-integ-tests/constants.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/aws-cdk/lib/cli/io-host/cli-io-host.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export class CliIoHost implements IIoHost {
}
}

const telemetryEndpoint = process.env.TELEMETRY_ENDPOINT;
const telemetryEndpoint = process.env.TELEMETRY_ENDPOINT ?? 'https://cdk-cli-telemetry.us-east-1.api.aws/metrics';
if (canCollectTelemetry(args, context) && telemetryEndpoint) {
try {
sinks.push(new EndpointTelemetrySink({
Expand Down
Loading