-
Notifications
You must be signed in to change notification settings - Fork 152
helper tool to add new security groups to FSxL ENIs #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # SPDX-License-Identifier: MIT-0 | ||
|
|
||
| declare -a HELP=( | ||
| "[-p|--profile]" | ||
| "[-r|--region]" | ||
| "[-f|--fsx-id]" | ||
| "[-s|--sg-id]" | ||
| ) | ||
|
|
||
| fsx_id="" | ||
| security_group="" | ||
| declare -a awscli_args=() | ||
|
|
||
| parse_args() { | ||
| local key | ||
| while [[ $# -gt 0 ]]; do | ||
| key="$1" | ||
| case $key in | ||
| -h|--help) | ||
| echo "Add security groups to existing Amazon FSx for Lustre ENI." | ||
| echo "Usage: $(basename ${BASH_SOURCE[0]}) ${HELP[@]}" | ||
| ;; | ||
| -p|--profile) | ||
| awscli_args+=(--profile "$2") | ||
| shift 2 | ||
| ;; | ||
| -r|--region) | ||
| awscli_args+=(--region "$2") | ||
| shift 2 | ||
| ;; | ||
| -s|--sg-id) | ||
| security_group="$2" | ||
| shift 2 | ||
| ;; | ||
| -f|--fsx-id) | ||
| fsx_id="$2" | ||
| shift 2 | ||
| ;; | ||
| *) | ||
| [[ "$fsx_id" == "" ]] \ | ||
| && $fsx_id="$key" \ | ||
| || { echo "Must define one file system id." ; exit -1; } | ||
| [[ "$security_group" == "" ]] \ | ||
| && $security_group="$key" \ | ||
| || { echo "Must define at least one security group id." ; exit -1; } | ||
| shift | ||
| ;; | ||
| esac | ||
| done | ||
|
|
||
| [[ "$fsx_id" == "" ]] || [[ "$security_group" == "" ]] && { echo "Must define at least one filesystem ID and security group ID"; exit -1; } | ||
| } | ||
|
|
||
| #===Style Definitions=== | ||
| GREEN='\033[0;32m' | ||
| BLUE='\033[0;34m' | ||
| YELLOW='\033[1;33m' | ||
| NC='\033[0m' # No Color | ||
|
|
||
| escape_spaces() { | ||
|
||
| local input="$1" | ||
| echo "${input// /\\ }" | ||
| } | ||
|
|
||
| print_header() { | ||
| echo -e "\n${BLUE}=================================================${NC}" | ||
| echo -e "\n${YELLOW} $1 " | ||
| echo -e "\n${BLUE}=================================================${NC}" | ||
| } | ||
|
|
||
| #### __main__ #### | ||
| parse_args $@ | ||
|
|
||
| print_header " 🚀 Amazon Sagemaker Hyperpod 🚀 \n \ | ||
| Amazon FSx for Lustre helper tool \n \ | ||
| This tool will help by adding new \n \ | ||
| security groups to the FSx for Lustre ENIs" | ||
|
|
||
| # First get one network interface then describe the network interface to get existing Security Groups attached | ||
| fsx_id_enis=$(aws fsx describe-file-systems "${awscli_args[@]}" --query 'FileSystems[0].NetworkInterfaceIds' --output text) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is getting ENIs for the first fsx found, and not really for defined $fsx_id. If there are multiple fsx, this will cause issues and might cause modifying wrong SG. We should be using $fsx_id here to make sure we are getting ENIs for correct fsx.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nope, this is getting the ENIs for the $fsx_id defined on the arguments passed to the script. If the user does not pass an fsx_id on the arguments, the script doesn't run. when the user pass the required arguments, then the This is the right syntax. |
||
| existing_sg=$(aws ec2 describe-network-interfaces "${awscli_args[@]}" --network-interface-ids $temp_eni_id --query 'NetworkInterfaces[0].Groups[*].GroupId' --output text) | ||
|
||
|
|
||
| if [[ -z "$fsx_id_enis" || -z "$existing_sg" ]]; then | ||
| echo -e "Error: No ENI or existing security group found. Exiting." | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo -e "Amazon FSx for Lustre filesystem: ${GREEN}${fsx_id}${NC}" | ||
| echo -e "Existing security groups attached on the filesystem: ${GREEN}${$existing_sg}${NC}" | ||
|
||
| echo -e "Adding security group ID: ${GREEN}${$security_group}${NC}" | ||
|
||
|
|
||
| # Finally update the ENI to add the new security groups plus the existing security groups | ||
| for i in $fsx_id_enis; do | ||
| echo -e "Adding ${GREEN}${$security_group} to ENI $GREEN}${$i}" | ||
|
||
| $(aws ec2 modify-network-interface-attribute "${awscli_args[@]}" --network-interface-id $i --groups $existing_sg $security_group) | ||
|
||
|
|
||
| [[ $? -ne 0 ]] && { echo "Failed adding $security_group to ENI $i"; exit -1; } | ||
| done | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be fsx_id="$key"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have to check for both. The syntax do:
fsx_idis emptykeytofsx_id.If the user does not provide a
fsx_idas part of the arguments, then the test will be FALSE. Thefsx_idwon't get assigned a value which will cause the script to exit.