Skip to content

missing engine is not a cause for panic #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

missing engine is not a cause for panic #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion SecretsManagerRDSMySQLRotationMultiUser/lambda_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,9 @@ def get_secret_dict(service_client, arn, stage, token=None):
secret_dict = json.loads(plaintext)

# Run validations against the secret
if 'engine' not in secret_dict or secret_dict['engine'] != 'mysql':
if 'engine' not in secret_dict:
secret_dict['engine'] = 'mysql'
if secret_dict['engine'] != 'mysql':
raise KeyError("Database engine must be set to 'mysql' in order to use this rotation lambda")
for field in required_fields:
if field not in secret_dict:
Expand Down
4 changes: 3 additions & 1 deletion SecretsManagerRDSMySQLRotationSingleUser/lambda_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,9 @@ def get_secret_dict(service_client, arn, stage, token=None):
secret_dict = json.loads(plaintext)

# Run validations against the secret
if 'engine' not in secret_dict or secret_dict['engine'] != 'mysql':
if 'engine' not in secret_dict:
secret_dict['engine'] = 'mysql'
if secret_dict['engine'] != 'mysql':
raise KeyError("Database engine must be set to 'mysql' in order to use this rotation lambda")
for field in required_fields:
if field not in secret_dict:
Expand Down
4 changes: 3 additions & 1 deletion SecretsManagerRDSPostgreSQLRotationMultiUser/lambda_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,9 @@ def get_secret_dict(service_client, arn, stage, token=None):
secret_dict = json.loads(plaintext)

# Run validations against the secret
if 'engine' not in secret_dict or secret_dict['engine'] != 'postgres':
if 'engine' not in secret_dict:
secret_dict['engine'] = 'postgres'
if secret_dict['engine'] != 'postgres':
raise KeyError("Database engine must be set to 'postgres' in order to use this rotation lambda")
for field in required_fields:
if field not in secret_dict:
Expand Down
4 changes: 3 additions & 1 deletion SecretsManagerRDSPostgreSQLRotationSingleUser/lambda_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,9 @@ def get_secret_dict(service_client, arn, stage, token=None):
secret_dict = json.loads(plaintext)

# Run validations against the secret
if 'engine' not in secret_dict or secret_dict['engine'] != 'postgres':
if 'engine' not in secret_dict:
secret_dict['engine'] = 'postgres'
if secret_dict['engine'] != 'postgres':
raise KeyError("Database engine must be set to 'postgres' in order to use this rotation lambda")
for field in required_fields:
if field not in secret_dict:
Expand Down