Skip to content

Fixing the output when supplying 'precision' #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avoidwork merged 3 commits into from
Sep 19, 2025
Merged

Fixing the output when supplying 'precision' #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fc96b8
Fixing the output when supplying 'precision'
avoidwork Sep 19, 2025
deedce4
Changing github actions to build the earliest supported version and t…
avoidwork Sep 19, 2025
f2b8a6f
Changing github actions to build the current
avoidwork Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [20.x, 22.x]
node-version: [24.x]

steps:
- name: Checkout Repository
Expand Down
2 changes: 2 additions & 0 deletions dist/filesize.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ const EXPONENT = "exponent";
const ROUND = "round";

// Special Characters and Values
const E = "e";
const EMPTY = "";
const PERIOD = ".";
const S = "s";
Expand Down Expand Up @@ -198,6 +199,7 @@ function filesize (arg, {
// Setting optional precision
if (precision > 0) {
result[0] = result[0].toPrecision(precision);
result[0] = result[0].split(E)[0];
}

// Applying custom symbol
Expand Down
2 changes: 2 additions & 0 deletions dist/filesize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const EXPONENT = "exponent";
const ROUND = "round";

// Special Characters and Values
const E = "e";
const EMPTY = "";
const PERIOD = ".";
const S = "s";
Expand Down Expand Up @@ -194,6 +195,7 @@ function filesize (arg, {
// Setting optional precision
if (precision > 0) {
result[0] = result[0].toPrecision(precision);
result[0] = result[0].split(E)[0];
}

// Applying custom symbol
Expand Down
2 changes: 1 addition & 1 deletion dist/filesize.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/filesize.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions dist/filesize.umd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const EXPONENT = "exponent";
const ROUND = "round";

// Special Characters and Values
const E = "e";
const EMPTY = "";
const PERIOD = ".";
const S = "s";
Expand Down Expand Up @@ -194,6 +195,7 @@ function filesize (arg, {
// Setting optional precision
if (precision > 0) {
result[0] = result[0].toPrecision(precision);
result[0] = result[0].split(E)[0];
}

// Applying custom symbol
Expand Down
2 changes: 1 addition & 1 deletion dist/filesize.umd.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading