Skip to content

Hotfix/improve the version experience for version 290 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidkallesen merged 4 commits into from
Jan 20, 2025
Merged

Hotfix/improve the version experience for version 290 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a611a4
chore: remove the version-pinned for xunit and xunit.extensibility.core
davidkallesen Jan 20, 2025
5a9bbde
build: bump coverlet.collector to 6.0.4
davidkallesen Jan 20, 2025
422ddfc
chore: add readme to solution
davidkallesen Jan 20, 2025
ce4c923
docs: update readme with some notes about the version
davidkallesen Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Atc.Test.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "test", "test", "{4B46C47D-D
test\Directory.Build.props = test\Directory.Build.props
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "docs", "docs", "{014851A9-0672-4268-9856-181B0BB26F71}"
ProjectSection(SolutionItems) = preProject
README.md = README.md
EndProjectSection
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

Common tools for writing tests using XUnit, AutoFixture, NSubstitute and FluentAssertions.

> **Version Notes:**
> If you are using the `MemberAutoNSubstituteData` attribute, ensure that both `xunit` and `xunit.extensibility.core` packages are set to version **2.9.0**.
> This is because the latest versions of xUnit are currently incompatible with `MemberAutoNSubstituteData` due to an unresolved issue. Although [xunit/xunit#3031](https://github.com/xunit/xunit/issues/3031) has been closed, the problem remains unresolved.
> Upgrading beyond version 2.9.0 may result in test failures or unexpected behavior.


## Test Attributes

| Name | Description |
Expand All @@ -12,7 +18,8 @@ Common tools for writing tests using XUnit, AutoFixture, NSubstitute and FluentA
| `InlineAutoNSubstituteData` | Provides a data source for a data theory, with the data coming from inline values combined with auto-generated data specimens generated by AutoFixture and NSubstitute.|
| `MemberAutoNSubstituteData` | Provides a data source for a data theory, with the data coming from one of the following sources and combined with auto-generated data specimens generated by AutoFixture and NSubstitute.|

Note: NSubstitute is used when the type being created is abstract, or when the `[Substitute]` is applied.
> **Note:**
> NSubstitute is used when the type being created is abstract, or when the `[Substitute]` is applied.

## Test Helpers

Expand Down
3 changes: 2 additions & 1 deletion src/Atc.Test/Atc.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
<PackageReference Include="NSubstitute" Version="5.3.0" />
<PackageReference Include="System.Net.Http" Version="4.3.4" />
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
<PackageReference Include="xunit.extensibility.core" Version="[2.9.0]" /> <!-- xunit.extensibility.core is version-pinned because versions newer than 2.9.0 introduce bugs -->
<PackageReference Include="xunit" Version="2.9.0" /> <!-- xunit should not be upgraded since newer version than 2.9.0 introduce bugs for MemberAutoNSubstituteDataAttribute -->
<PackageReference Include="xunit.extensibility.core" Version="2.9.0" /> <!-- xunit.extensibility.core should not be upgraded since newer version than 2.9.0 introduce bugs for MemberAutoNSubstituteDataAttribute -->
<PackageReference Include="System.Text.Json" Version="8.0.5" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion test/Atc.Test.Tests/Atc.Test.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="6.0.3">
<PackageReference Include="coverlet.collector" Version="6.0.4">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
Loading