-
Notifications
You must be signed in to change notification settings - Fork 1
Upgrade to .NET 10 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…et packages and target .NET 10, update coding rules
…I project with MudBlazor
…emblies Use DocumentFilterContext to build schema-to-type mapping instead of AppDomain scanning, enabling correct enum description generation when multiple assemblies define enums with identical names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the library from .NET 8/9 to .NET 10, bumps the major version to 2.0, and introduces significant enhancements including nested [FromBody] validator discovery, Scalar API documentation, improved error handling, and comprehensive test coverage.
Key Changes:
- Upgrade to .NET 10 with LangVersion 14.0 and migration from
.slnto.slnxformat - Add nested
[FromBody]property validation with automatic validator discovery - Introduce Scalar API reference UI alongside Swagger, with OpenAPI 3.1 support
- Migrate testing infrastructure to Microsoft.Testing.Platform and xUnit v3
Reviewed changes
Copilot reviewed 100 out of 100 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version.json | Bumped library version from 1.0 to 2.0 |
| Directory.Build.props | Updated TargetFramework to net10.0 and LangVersion to 14.0 |
| test/Directory.Build.props | Added Microsoft.Testing.Platform dependencies and xUnit v3 packages |
| src/Atc.Rest.MinimalApi/Middleware/GlobalErrorHandlingMiddleware.cs | Added OperationCanceledException handling, response started checks, and valid JSON generation |
| src/Atc.Rest.MinimalApi/Filters/Swagger/SwaggerEnumDescriptionsDocumentFilter.cs | Fixed enum type lookup for duplicate names and updated for Microsoft.OpenApi v2.x |
| src/Atc.Rest.MinimalApi/Filters/Endpoints/ValidationFilter.cs | Added nested [FromBody] property validation with automatic validator discovery |
| src/Atc.Rest.MinimalApi/Extensions/ValidationProblemExtensions.cs | Fixed validation error merging to prevent duplicate keys |
| src/Atc.Rest.MinimalApi/Atc.Rest.MinimalApi.csproj | Updated to net10.0 and upgraded NuGet packages including Scalar.AspNetCore |
| sample/src/Demo.AppHost/* | Added Aspire AppHost project for orchestration |
| sample/src/Demo.Web/* | Added Blazor Web UI with MudBlazor for CRUD operations demo |
| sample/src/Demo.Domain/Validators/UpdateUserRequestValidator.cs | Implemented partial update validation (PATCH-like behavior) |
| README.md | Expanded documentation with .NET 10 guidance, Scalar setup, and nested validation examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Major upgrade to .NET 10 with significant improvements to validation, API documentation, sample project architecture, and code quality.
🚀 .NET 10 Migration
.slnto.slnxformat✨ New Features
Validation Enhancements
[FromBody]property validation with automatic validator discoveryAPI Documentation
Sample Project
🐛 Bug Fixes
Middleware
Validation
Activator.CreateInstanceexceptions gracefullyFirstOrDefaultto avoid exception with multiple parameter matchesSample Project
SaveChangesAsyncin all handlersUri.TryCreateto preventUriFormatException🧪 Tests
📚 Documentation
🔧 Code Quality
Breaking Changes