Feature/multiple map support #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dictionary based support for multiple simultaneous maps. I tried to keep it backward compatible so old code should work like it used to in case of a single map. Practically this means that in cases without a map id defined for a call, it will try to use the last added map, or a remaining map if the latest has been removed. Implements #64
Data Sources, etc. can currently only be attached to a single map, though it might be good to be able to use a common data source for multiple maps in some cases.
It seems to slightly increase the likelyhood of #102 and map not being visible (= having height 0) if the container does not have a set height. Some of the samples also try to access outdated endpoints, e.g. indoor service, so I wasn't able to test those.