-
-
Notifications
You must be signed in to change notification settings - Fork 15
Automatic Library Installation from depends field in library.properties
#205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 99.81% 99.75% -0.06%
==========================================
Files 2 2
Lines 1608 1665 +57
==========================================
+ Hits 1605 1661 +56
- Misses 3 4 +1 ☔ View full report in Codecov by Sentry. |
|
@per1234 Can you approve this PR? |
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit test coverage for the added code.
|
|
There is an error in one workflow, which I don't think is related to this PR. |
This PR addresses the limitation described by @per1234 in arduino-libraries/Arduino_UnifiedStorage#30 (review)
Currently, the compile-sketches action is unable to read dependancies from the
dependsfield. I have documented this issue in #204 .library.propertiesis included in the sketch directorydependskey usingre(limitation: only with ',' deliminator)install_libraries_from_library_manager()function to install identified libraries.ymlfile cc @sebromero