[skip changelog] Bump golangci/golangci-lint-action from 6 to 7 #2872
+174
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 7. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6...v7) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
cmaglie
force-pushed
the
dependabot/github_actions/golangci/golangci-lint-action-7
branch
from
022c94d to
0441aa9
Compare
commands/service_compile.go:162:5: QF1001: could apply De Morgan's law (staticcheck)
if !(keychainProp == signProp && signProp == encryptProp) {
commands/service_compile.go:248:16: ST1023: should omit type logger.Verbosity from declaration; it will be inferred from the right-hand side (staticcheck)
var verbosity logger.Verbosity = logger.VerbosityNormal
^
commands/service_compile.go:356:4: QF1012: Use fmt.Fprintf(...) instead of Write([]byte(fmt.Sprintf(...))) (staticcheck)
outStream.Write([]byte(fmt.Sprintf("Could not normalize FQBN: %s\n", err)))
^
commands/service_compile.go:359:3: QF1012: Use fmt.Fprintf(...) instead of Write([]byte(fmt.Sprintf(...))) (staticcheck)
outStream.Write([]byte(fmt.Sprintf("FQBN: %s\n", normalizedFQBN)))
^
commands/service_upload.go:508:4: QF1012: Use fmt.Fprintln(...) instead of Write([]byte(fmt.Sprintln(...))) (staticcheck)
outStream.Write([]byte(fmt.Sprintln(i18n.Tr("Skipping 1200-bps touch reset: no serial port selected!"))))
^
commands/service_upload.go:515:6: QF1012: Use fmt.Fprintln(...) instead of Write([]byte(fmt.Sprintln(...))) (staticcheck)
outStream.Write([]byte(fmt.Sprintln(i18n.Tr("Performing 1200-bps touch reset on serial port %s", portAddress))))
^
commands/service_upload.go:521:6: QF1012: Use fmt.Fprintln(...) instead of Write([]byte(fmt.Sprintln(...))) (staticcheck)
outStream.Write([]byte(fmt.Sprintln(i18n.Tr("Waiting for upload port..."))))
^
internal/arduino/builder/internal/preprocessor/ctags.go:68:3: QF1012: Use fmt.Fprintf(...) instead of WriteString(fmt.Sprintf(...)) (staticcheck)
stderr.WriteString(fmt.Sprintf("%s: %s",
^
internal/mock_serial_monitor/main.go:146:4: QF1012: Use fmt.Fprintf(...) instead of Write([]byte(fmt.Sprintf(...))) (staticcheck)
d.mockedSerialPort.Write([]byte(
^
commands/service_upload.go:532:7: QF1012: Use fmt.Fprintln(...) instead of Write([]byte(fmt.Sprintln(...))) (staticcheck)
outStream.Write([]byte(fmt.Sprintln(i18n.Tr("Upload port found on %s", portAddress))))
^
commands/service_upload.go:534:7: QF1012: Use fmt.Fprintln(...) instead of Write([]byte(fmt.Sprintln(...))) (staticcheck)
outStream.Write([]byte(fmt.Sprintln(i18n.Tr("No upload port found, using %s as fallback", actualPort.Address))))
^
commands/service_upload.go:544:4: QF1012: Use fmt.Fprintln(...) instead of Write([]byte(fmt.Sprintln(...))) (staticcheck)
errStream.Write([]byte(fmt.Sprintln(i18n.Tr("Cannot perform port reset: %s", err))))
^
commands/service_upload.go:731:3: QF1012: Use fmt.Fprintln(...) instead of Write([]byte(fmt.Sprintln(...))) (staticcheck)
outStream.Write([]byte(fmt.Sprintln(cmdLine)))
^
internal/arduino/builder/internal/utils/utils.go:85:25: QF1004: could use strings.ReplaceAll instead (staticcheck)
rows := strings.Split(strings.Replace(depFile, "\r\n", "\n", -1), "\n")
^
Member
|
This PR required also:
|
internal/arduino/cores/packagemanager/loader.go:368:6: QF1006: could lift into loop condition (staticcheck)
if !board.Properties.ContainsKey(fmt.Sprintf("upload_port.%d.vid", i)) {
^
internal/cli/lib/check_deps.go:117:2: QF1003: could use tagged switch on dep.VersionInstalled (staticcheck)
if dep.VersionInstalled == "" {
^
cmaglie
force-pushed
the
dependabot/github_actions/golangci/golangci-lint-action-7
branch
from
6c51f8b to
f69bff3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2872 +/- ##
=======================================
Coverage 67.87% 67.88%
=======================================
Files 238 238
Lines 22412 22410 -2
=======================================
Hits 15212 15212
+ Misses 6005 6004 -1
+ Partials 1195 1194 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Xayton
approved these changes
Apr 3, 2025
cmaglie
deleted the
dependabot/github_actions/golangci/golangci-lint-action-7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps golangci/golangci-lint-action from 6 to 7.
Release notes
Sourced from golangci/golangci-lint-action's releases.
... (truncated)
Commits
14814047.0.0dec74fafeat: golangci-lint v2 support (#1198)1f07148build(deps-dev): bump the dev-dependencies group with 3 updates (#1207)9938e10docs: fix checks permissions for annotations (#1204)b91d580docs: update annotation permissions (#1203)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)