Skip to content

Skip archive (.a) creation if the archive is already up-to-date #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Skip archive (.a) creation if the archive is already up-to-date #1778

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b45e7bb
Skip archive (.a) creation if the archive is already up-to-date
cmaglie Jun 20, 2022
9bd93a5
Reduce verbosity
cmaglie Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion legacy/builder/phases/linker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,9 @@ func link(ctx *types.Context, objectFiles paths.PathList, coreDotARelPath *paths
for _, a := range archives {
filesToLink.Add(a.ArchivePath)
if a.IsUpToDate() {
ctx.Info(fmt.Sprintf("%s %s", tr("Using previously build archive:"), a.ArchivePath))
if ctx.Verbose {
ctx.Info(fmt.Sprintf("%s %s", tr("Using previously build archive:"), a.ArchivePath))
Copy link
Collaborator

@matthijskooijman matthijskooijman Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, I think there's a typo here too: s/build/built/

}
continue
}
if err := a.Create(ctx, arPattern); err != nil {
Expand Down