Skip to content

Wire: Fix write() returning incorrect byte count on buffer overflow (See issue #597) #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tranomial wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Wire: Fix write() returning incorrect byte count on buffer overflow (See issue #597) #612

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62da873
Bump actions/checkout from 5 to 6
dependabot[bot] Nov 20, 2025
685820f
Wire: Fix write() returning incorrect byte count on buffer overflow (…
Tranomial Nov 22, 2025
a026632
Merge branch 'arduino:master' into WireWriteFix
Tranomial Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions libraries/Wire/src/Wire.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,16 +265,20 @@ size_t TwoWire::write(uint8_t data)
size_t TwoWire::write(const uint8_t *data, size_t quantity)
{
if(transmitting){
// in master transmitter mode
// in master transmitter mode
uint8_t bytesSent = 0;
// number of bytes successfully added to the buffer
for(size_t i = 0; i < quantity; ++i){
write(data[i]);
}
if (write(data[i]) == 1) // if a byte was successfully added to the buffer
bytesSent++;
}
return bytesSent;
}else{
// in slave send mode
// reply to master
twi_transmit(data, quantity);
return quantity;
}
return quantity;
}

// must be called in:
Expand Down
Loading