Add phpdoc for array of some interface #7583
Open
+44
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
phpdoc
branch
from
c5c4ee5 to
919f0b0
Compare
soyuka
reviewed
Dec 4, 2025
| - src/State/Tests | ||
| - src/Symfony/Tests | ||
| - tests | ||
| - src # TODO |
Member
There was a problem hiding this comment.
do we really want to add src here?
Contributor
Author
There was a problem hiding this comment.
There is currently 1500 errors of missingType.iterableValue so I cannot fix all of them
I thought it could be interesting that one day all the existing array from /src folder are described by a PHPdoc no? So currently src is ignored (which is already the case) and one day it won't. WDYT ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using PHPStan, array are recommended to be typehinted.
When implementing interface from ApiPlatform, I get error because there are not described. It's kinda annoying having to add
array<mixed>while the phpdoc could be improved on ApiPlatform side.