fix: consistent :property placeholder behavior #7547
Merged
+654
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinarnt
suggested changes
Nov 20, 2025
| use PHPUnit\Framework\Attributes\DataProvider; | ||
|
|
||
| /** | ||
| * @author Votre Nom <votre@email.com> |
Contributor
There was a problem hiding this comment.
You need to replace it with your name and email
src/Metadata/Resource/Factory/ParameterResourceMetadataCollectionFactory.php
Outdated
Show resolved
Hide resolved
soyuka
reviewed
Nov 21, 2025
| properties: ['description', 'name'] | ||
| ), | ||
| ] | ||
| )] |
Member
There was a problem hiding this comment.
can you add one to the https://github.com/api-platform/core/blob/main/tests/Fixtures/TestBundle/Entity/SearchFilterParameter.php class?
| $this->loadFixtures(); | ||
| } | ||
|
|
||
| #[DataProvider('partialFilterParameterProvider')] |
Member
There was a problem hiding this comment.
please add these tests to the DoctrineTest file
src/Metadata/Resource/Factory/ParameterResourceMetadataCollectionFactory.php
Outdated
Show resolved
Hide resolved
soyuka
force-pushed
the
fix-partial-exact-filter-property-placeholder
branch
11 times, most recently
from
8252ea7 to
c109c09
Compare
soyuka
changed the title
soyuka
force-pushed
the
fix-partial-exact-filter-property-placeholder
branch
from
c109c09 to
a3313f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes
This patch introduces a significant internal refactoring to how parameters are processed and applied to filters across API Platform's core, Doctrine, GraphQL, and Laravel integrations. The primary goal is to centralize and solidify parameter handling, particularly for filters that can operate on multiple properties using the
:propertyplaceholder.Filters will now receive a more precise context. During the
applymethod,$context['filters']will contain only the values directly relevant to the specific filter being processed. This simplifies filter implementation, and developers are encouraged to use$parameter->getValue()for direct access to their parameter's associated value.The
:propertyplaceholder in parameter keys is now integrates with thegetProperties()method ofPropertyAwareFilterInterfaceimplementations. This resolves previous inconsistencies and solidifies the behavior where:propertyplaceholders are dynamically expanded and filled with the content ofgetProperties, ensuring a more predictable and consistent approach for filters that target multiple properties.This is a risky change as it fundamentally alters how certain parameters, especially those using dynamic properties, are processed and how filters receive their values. The previous parameter handling, particularly concerning the interaction between
getPropertieson parameters and dynamic property expansion, was inconsistent and did not work properly in all scenarios. This patch solidifies that behavior.