Skip to content

Conversation

@snoopdave
Copy link
Contributor

@snoopdave snoopdave commented Jan 20, 2025

This PR introduces improved session management capabilities to Roller:

  • Added RollerLoginSessionManager to provide centralized session tracking
  • Enhanced RollerSession to integrate with the new session management system
  • Updated UserEdit to handle session state changes
  • Added comprehensive test coverage for new functionality

The changes provide better control over user sessions and improve overall application reliability.

Testing:

  • Added RollerLoginSessionManagerTest with full coverage of new functionality
  • Added RollerSessionTest to verify session behavior
  • All existing tests pass

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good! unfortunately I haven't had time to test it manually - but tests look good too.

@snoopdave snoopdave changed the title Session management improvements simple Enhanced Session Management in Apache Roller Jan 26, 2025
@snoopdave snoopdave merged commit cd5139a into master Feb 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants