This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[FEATURE][OP] Support FInplaceIdentity property for legacy operators #20710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We notice that only nnvm operators support
FInplaceIdentityproperty but legacy operators do not, which leads toInplaceOptionfailing when the storage reference count is large than 1. We addFInplaceIdentitysupport for legacy operators in this PR.Checklist
Essentials
Changes
Comments