Skip to content

JUnit Jupiter best practices #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

JUnit Jupiter best practices #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/test/java/org/apache/maven/plugins/source/SourceJarMojoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
* @author <a href="mailto:oching@exist.com">Maria Odea Ching</a>
*/
@MojoTest
public class SourceJarMojoTest extends AbstractSourcePluginTestCase {
class SourceJarMojoTest extends AbstractSourcePluginTestCase {

private String[] addMavenDescriptor(String project, String... listOfElements) {
final String metainf = "META-INF/";
Expand All @@ -65,7 +65,7 @@ private String[] addMavenDescriptor(String project, String... listOfElements) {
@InjectMojo(goal = "jar")
@Basedir("${basedir}/target/test-classes/unit/project-001")
@MojoParameter(name = "classifier", value = "sources")
void testDefaultConfiguration(AbstractSourceJarMojo mojo) throws Exception {
void defaultConfiguration(AbstractSourceJarMojo mojo) throws Exception {
mojo.execute();

File target = new File(getBasedir(), "target");
Expand All @@ -85,7 +85,7 @@ void testDefaultConfiguration(AbstractSourceJarMojo mojo) throws Exception {
@Test
@InjectMojo(goal = "jar")
@Basedir("${basedir}/target/test-classes/unit/project-003")
public void testExcludes(AbstractSourceJarMojo mojo) throws Exception {
void excludes(AbstractSourceJarMojo mojo) throws Exception {
mojo.execute();

File target = new File(getBasedir(), "target");
Expand All @@ -105,7 +105,7 @@ public void testExcludes(AbstractSourceJarMojo mojo) throws Exception {
@Test
@InjectMojo(goal = "jar")
@Basedir("${basedir}/target/test-classes/unit/project-005")
public void testNoSources(AbstractSourceJarMojo mojo) throws Exception {
void noSources(AbstractSourceJarMojo mojo) throws Exception {
mojo.execute();

// Now make sure that no archive got created
Expand All @@ -118,7 +118,7 @@ public void testNoSources(AbstractSourceJarMojo mojo) throws Exception {
@Test
@InjectMojo(goal = "jar")
@Basedir("${basedir}/target/test-classes/unit/project-007")
public void testIncludes(AbstractSourceJarMojo mojo) throws Exception {
void includes(AbstractSourceJarMojo mojo) throws Exception {
mojo.execute();

File target = new File(getBasedir(), "target");
Expand All @@ -139,7 +139,7 @@ public void testIncludes(AbstractSourceJarMojo mojo) throws Exception {
@Test
@InjectMojo(goal = "jar")
@Basedir("${basedir}/target/test-classes/unit/project-009")
public void testIncludePom(AbstractSourceJarMojo mojo) throws Exception {
void includePom(AbstractSourceJarMojo mojo) throws Exception {
mojo.execute();

File target = new File(getBasedir(), "target");
Expand All @@ -160,7 +160,7 @@ public void testIncludePom(AbstractSourceJarMojo mojo) throws Exception {
@Test
@InjectMojo(goal = "jar")
@Basedir("${basedir}/target/test-classes/unit/project-010")
public void testIncludeMavenDescriptorWhenExplicitlyConfigured(AbstractSourceJarMojo mojo) throws Exception {
void includeMavenDescriptorWhenExplicitlyConfigured(AbstractSourceJarMojo mojo) throws Exception {
mojo.execute();

File target = new File(getBasedir(), "target");
Expand Down
10 changes: 5 additions & 5 deletions src/test/java/org/apache/maven/plugins/source/TestSourceJarMojoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@
* @author <a href="mailto:oching@exist.com">Maria Odea Ching</a>
*/
@MojoTest
public class TestSourceJarMojoTest extends AbstractSourcePluginTestCase {
class TestSourceJarMojoTest extends AbstractSourcePluginTestCase {

@Test
@InjectMojo(goal = "test-jar")
@Basedir("${basedir}/target/test-classes/unit/project-001")
@MojoParameter(name = "classifier", value = "test-sources")
public void testDefaultConfiguration(AbstractSourceJarMojo mojo) throws Exception {
void defaultConfiguration(AbstractSourceJarMojo mojo) throws Exception {
mojo.execute();

File target = new File(getBasedir(), "target");
Expand All @@ -75,7 +75,7 @@ public void testDefaultConfiguration(AbstractSourceJarMojo mojo) throws Exceptio
@InjectMojo(goal = "test-jar")
@Basedir("${basedir}/target/test-classes/unit/project-003")
@MojoParameter(name = "classifier", value = "test-sources")
public void testExcludes(AbstractSourceJarMojo mojo) throws Exception {
void excludes(AbstractSourceJarMojo mojo) throws Exception {
mojo.execute();

File target = new File(getBasedir(), "target");
Expand All @@ -99,7 +99,7 @@ public void testExcludes(AbstractSourceJarMojo mojo) throws Exception {
@InjectMojo(goal = "test-jar")
@Basedir("${basedir}/target/test-classes/unit/project-005")
@MojoParameter(name = "classifier", value = "test-sources")
public void testNoSources(AbstractSourceJarMojo mojo) throws Exception {
void noSources(AbstractSourceJarMojo mojo) throws Exception {
mojo.execute();

// Now make sure that no archive got created
Expand All @@ -113,7 +113,7 @@ public void testNoSources(AbstractSourceJarMojo mojo) throws Exception {
@InjectMojo(goal = "test-jar")
@Basedir("${basedir}/target/test-classes/unit/project-010")
@MojoParameter(name = "classifier", value = "test-sources")
public void testIncludeMavenDescriptorWhenExplicitlyConfigured(AbstractSourceJarMojo mojo) throws Exception {
void includeMavenDescriptorWhenExplicitlyConfigured(AbstractSourceJarMojo mojo) throws Exception {
mojo.execute();

File target = new File(getBasedir(), "target");
Expand Down
Loading