[MRESOURCES-284] Support JSON format for parameter filter files #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
changed the title
elharo
reviewed
Jan 9, 2025
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
Needs more tests. If you want to proceed with this please update to master and add tests. Otherwise it will eventually be closed.
|
|
||
| /** | ||
| * This parameter is used in particular for filters properties files with format json. | ||
| * if this parameter is not empty, we select all the parameters who are the nodes start with this parameter |
|
|
||
| /** | ||
| * load property test case can be adjusted by modifying the basic.properties and basic_validation properties | ||
| * I added a null for this parameter (rootNode) because it is only used with json file @ImadBL |
Contributor
There was a problem hiding this comment.
This shouldn't be an API doc comment
elharo
requested changes
Feb 13, 2025
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
I'm not sure this is a good idea, but if it is, it still needs documentation in this PR before it could be merged.That is, also add docs for this feature, not just code.
|
Resolve #129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This concerns the maven-resources-plugin (3.2.1-SNAPSHOT) and maven-filtering (3.3.0-SNAPSHOT) plugins.
with this evolution it is now possible to add configuration files with json format. the second part of this evolution is to have to use a one configuration json file for all environments (dev, preprod, prod...etc )
for more example check: MRESOURCES-284
please note that you must accept the PR first for maven-filtering (3.3.0-SNAPSHOT)
because maven-resources-plugin (3.2.1-SNAPSHOT) need maven-filtering (3.3.0-SNAPSHOT)
if you have any questions do not hesitate, hoping that I have detailed well
Best regards
Imad BELMOUJAHID
@ImadBL