Skip to content

Conversation

@Caideyipi
Copy link
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 25.77904% with 262 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.30%. Comparing base (9b3bdc4) to head (bf72c19).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...e/sink/protocol/opcua/client/IoTDBOpcUaClient.java 0.00% 107 Missing ⚠️
...e/iotdb/db/pipe/sink/protocol/opcua/OpcUaSink.java 52.25% 53 Missing ⚠️
...otocol/opcua/client/IoTDBKeyStoreLoaderClient.java 0.00% 46 Missing ⚠️
.../pipe/sink/protocol/opcua/client/ClientRunner.java 0.00% 42 Missing ⚠️
...sink/protocol/opcua/server/OpcUaServerBuilder.java 69.56% 7 Missing ⚠️
...ipe/sink/protocol/opcua/server/OpcUaNameSpace.java 75.00% 5 Missing ⚠️
...ueryengine/plan/relational/sql/ast/CreatePipe.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16944      +/-   ##
============================================
+ Coverage     39.18%   39.30%   +0.11%     
  Complexity      212      212              
============================================
  Files          5053     5056       +3     
  Lines        335671   337498    +1827     
  Branches      42812    42955     +143     
============================================
+ Hits         131525   132637    +1112     
- Misses       204146   204861     +715     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Caideyipi Caideyipi changed the title Pipe: Implemented OPC Sink for outer server Pipe: Implemented OPC Sink for outer server & Set configuration and changed the default value of the server security policies Dec 24, 2025
@Caideyipi Caideyipi changed the title Pipe: Implemented OPC Sink for outer server & Set configuration and changed the default value of the server security policies Pipe: Implemented OPC Sink for outer server & Set configuration and changed the default value of the server security policies & Made the default quality configurable and does not throw when non-value/quality measurement is encountered Dec 25, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant