IGNITE-26209 Add metrics to improve node network unavailability detection #12339
Conversation
alex-plekhanov
force-pushed
the
ignite-26209
branch
from
855a8e1 to
bf092f5
Compare
|
| * @return {@code this} for chaining. | ||
| */ | ||
| @IgniteSpiConfiguration(optional = true) | ||
| public TcpCommunicationSpi setMessageQueueWarningSize(int msgQueueWarnSize) { |
There was a problem hiding this comment.
queueWarningSize and queueLimit looks coupled to me.
If we make queueLimit bigger then warning size must become bigger too.
Can we make this new proeprty double?
So queueWarningSize depends on queueLimit.
and actual warning limit will be equal to queueLimit * warningFactor
There was a problem hiding this comment.
Do we want to make this new API stable from the first merge?
Do we need IgniteExperimental annotation here?
There was a problem hiding this comment.
These parameters solve different problems. Queue limit - it's an OOM protection, warning size - it's an diagnostic. They can be set independently, for example, queue limit can be 0, while warning size more than 0, so warning size it's not a factor of queue limit.
About IgniteExperimental - it's just a one parameter for log warning, not an entire subsystem, I think setting annotation for each minor fix is overkill.
...ore/src/main/java/org/apache/ignite/spi/communication/tcp/internal/GridNioServerWrapper.java
Outdated
Show resolved
Hide resolved
|
2 participants
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.