Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ jobs:
matrix:
test-suite:
- { name: "default", args: "--all-targets --all-features --workspace" }
- { name: "smol", args: "--all-targets --no-default-features --features smol --features storage-all --workspace" }
- { name: "doc", args: "--doc --all-features --workspace" }
name: Unit Tests (${{ matrix.test-suite.name }})
steps:
Expand Down
189 changes: 6 additions & 183 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ serde_derive = "1.0.219"
serde_json = "1.0.142"
serde_repr = "0.1.16"
serde_with = "3.4"
smol = "2.0.2"
sqllogictest = "0.28.3"
sqlx = { version = "0.8.1", default-features = false }
stacker = "0.1.20"
Expand Down
5 changes: 1 addition & 4 deletions crates/iceberg/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ license = { workspace = true }
repository = { workspace = true }

[features]
default = ["storage-memory", "storage-fs", "storage-s3", "tokio"]
default = ["storage-memory", "storage-fs", "storage-s3"]
storage-all = ["storage-memory", "storage-fs", "storage-s3", "storage-gcs"]

storage-azdls = ["opendal/services-azdls"]
Expand All @@ -39,8 +39,6 @@ storage-memory = ["opendal/services-memory"]
storage-oss = ["opendal/services-oss"]
storage-s3 = ["opendal/services-s3", "reqsign"]

smol = ["dep:smol"]
tokio = ["tokio/rt-multi-thread"]

[dependencies]
anyhow = { workspace = true }
Expand Down Expand Up @@ -85,7 +83,6 @@ serde_derive = { workspace = true }
serde_json = { workspace = true }
serde_repr = { workspace = true }
serde_with = { workspace = true }
smol = { workspace = true, optional = true }
strum = { workspace = true, features = ["derive"] }
thrift = { workspace = true }
tokio = { workspace = true, optional = false, features = ["sync"] }
Expand Down
8 changes: 8 additions & 0 deletions crates/iceberg/src/io/storage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@
// specific language governing permissions and limitations
// under the License.

#[cfg(any(
feature = "storage-s3",
feature = "storage-gcs",
feature = "storage-oss",
feature = "storage-azdls",
))]
use std::sync::Arc;

use opendal::layers::RetryLayer;
Expand Down Expand Up @@ -71,6 +77,7 @@ impl Storage {
/// Convert iceberg config to opendal config.
pub(crate) fn build(file_io_builder: FileIOBuilder) -> crate::Result<Self> {
let (scheme_str, props, extensions) = file_io_builder.into_parts();
let _ = (&props, &extensions);
let scheme = Self::parse_scheme(&scheme_str)?;

match scheme {
Expand Down Expand Up @@ -127,6 +134,7 @@ impl Storage {
path: &'a impl AsRef<str>,
) -> crate::Result<(Operator, &'a str)> {
let path = path.as_ref();
let _ = path;
let (operator, relative_path): (Operator, &str) = match self {
#[cfg(feature = "storage-memory")]
Storage::Memory(op) => {
Expand Down
Loading
Loading