feat(datafusion): Add sqllogictest for DataFusion INSERT INTO #1887
+200
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| catalog.create_namespace(&namespace, HashMap::new()).await?; | ||
|
|
||
| // Create test tables | ||
| Self::create_unpartitioned_table(&catalog, &namespace).await?; |
Contributor
There was a problem hiding this comment.
Why we don't do this using sql?
Collaborator
Author
There was a problem hiding this comment.
Discussed with @liurenjie1024 offline, that currently we don't support CREATE TABLE yet and it should be ok to move forward with the pre-created table. Plus these tables can be useful when testing CREATE EXTERNAL TABLE
Contributor
There was a problem hiding this comment.
Please create an issue to track the support of creating table and add a TODO comment here.
liurenjie1024
approved these changes
Dec 5, 2025
| catalog.create_namespace(&namespace, HashMap::new()).await?; | ||
|
|
||
| // Create test tables | ||
| Self::create_unpartitioned_table(&catalog, &namespace).await?; |
Contributor
There was a problem hiding this comment.
Please create an issue to track the support of creating table and add a TODO comment here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
INSERT INTO#1835What changes are included in this PR?
Are these changes tested?
It's a test itself