Skip to content

Disable settings_push_enable on the H2Config for H2ServerBootstrap #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ok2c merged 3 commits into from
Dec 28, 2025
+4 −1
Merged

Disable settings_push_enable on the H2Config for H2ServerBootstrap #591

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5171201
Disable settings_push_enable on the H2Config.
CoolTomatos Dec 26, 2025
b3ca76a
Address comments.
CoolTomatos Dec 26, 2025
370f2e7
Address comments.
CoolTomatos Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...ore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2ServerBootstrap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@
@SuppressWarnings("deprecation")
public class H2ServerBootstrap {

private static final H2Config DEFAULT_H2_CONFIG = H2Config.custom().setPushEnabled(false).build();

private final List<RequestRouter.Entry<Supplier<AsyncServerExchangeHandler>>> routeEntries;
private final List<FilterEntry<AsyncFilterHandler>> filters;
private String canonicalHostName;
Expand Down Expand Up @@ -163,6 +165,7 @@ public final H2ServerBootstrap setVersionPolicy(final HttpVersionPolicy versionP
* @return this instance.
*/
public final H2ServerBootstrap setH2Config(final H2Config h2Config) {
Args.check(!h2Config.isPushEnabled(), "A server MUST NOT set enable_push to true");
this.h2Config = h2Config;
return this;
}
Expand Down Expand Up @@ -522,7 +525,7 @@ public HttpAsyncServer create() {
final ServerH2StreamMultiplexerFactory http2StreamHandlerFactory = new ServerH2StreamMultiplexerFactory(
httpProcessor != null ? httpProcessor : H2Processors.server(),
handlerFactory,
h2Config != null ? h2Config : H2Config.DEFAULT,
h2Config != null ? h2Config : DEFAULT_H2_CONFIG,
charCodingConfig != null ? charCodingConfig : CharCodingConfig.DEFAULT,
h2StreamListener,
frameFactory);
Expand Down
Loading